[bisq-network/bisq] Build out 'createoffer' API method (#4559)
Stan
notifications at github.com
Fri Oct 2 18:23:14 UTC 2020
> > The `createoffer` and `createpaymentacct` methods have complex argument lists, and different devs may want them defined in in different ways. We should discuss?
> > Right now, `createoffer` also places the offer, and problems might be created by placing it before giving users a chance to review details first. I thought the default behavior should be to cache the new offer (with ID) in the daemon, show it to the user, and let them place the new offer with a different `confirmoffer offer-id` command. But I need some consensus on that too.
>
> For an API I'm not sure there is a use case for the `confirm offer` extra step. Automated code wouldn't gain anything and UIs should probably implement that locally.
I was sure `placeoffer` was need, but if you and @chimp1984 think not, OK. I closed the `placeoffer` PR https://github.com/bisq-network/bisq/pull/4574.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4559#issuecomment-702887954
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20201002/f4091f55/attachment.html>
More information about the bisq-github
mailing list