[bisq-network/bisq] Build out 'createoffer' API method (#4559)

[sqrrm]

@sqrrm commented on this pull request.



> -        taskHandler.handleErrorMessage(errorMessage);
+        taskHandler.handleErrorMessage(t.getMessage());

I would like to exclude this change from this PR. It would affect the UI notifications that depend on the errormessage being reasonable for display.

Generally refactoring is fine (although more care is needed now with the many big PRs coming in, to avoid conflicts) and behavioral changes are fine as long as the ramifications are taken into account, I feel that's lacking here.

That's the only issue I have left. The rest looks good.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4559#pullrequestreview-501541716
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20201003/ec87eacd/attachment.html>