[bisq-network/bisq] Improve bisq setup (#4592)

[sqrrm]

@sqrrm commented on this pull request.



> +        walletsSetup.downloadPercentageProperty().addListener((observable, oldValue, newValue) -> {
+            if (walletsSetup.isDownloadComplete())
+                isBlockDownloadComplete.set(true);
+        });
+
+        walletsSetup.numPeersProperty().addListener((observable, oldValue, newValue) -> {
+            if (walletsSetup.hasSufficientPeersForBroadcast())
+                hasSufficientPeersForBroadcast.set(true);
+        });
+
+        p2pNetworkAndWalletInitialized = EasyBind.combine(updatedDataReceived,
+                isBlockDownloadComplete,
+                hasSufficientPeersForBroadcast,
+                allDomainServicesInitialized,
+                (a, b, c, d) -> {
+                    if (a && b && c) {

Why is this check excluding `allDomainServicesInitialized`? I couldn't figure the use for this `walletAndNetworkReady` and it seems to be not used. Is there a plan for future usage or could it be removed?

> +    public boolean isWalletAndNetworkReady() {
+        return walletAndNetworkReady.get();
+    }
+
+    public ReadOnlyBooleanProperty walletAndNetworkReadyProperty() {
+        return walletAndNetworkReady;
+    }
+
+    public boolean isAllDomainServicesInitialized() {
+        return allDomainServicesInitialized.get();
+    }
+
+    public ReadOnlyBooleanProperty allDomainServicesInitializedProperty() {
+        return allDomainServicesInitialized;
+    }
+
+    public boolean isApplicationFullyInitialized() {
+        return applicationFullyInitialized.get();
+    }
+
+    public ReadOnlyBooleanProperty applicationFullyInitializedProperty() {
+        return applicationFullyInitialized;
+    }
+
+    public boolean isUpdatedDataReceived() {
+        return updatedDataReceived.get();
+    }
+
+    public ReadOnlyBooleanProperty updatedDataReceivedProperty() {
+        return updatedDataReceived;
+    }
+
+    public boolean isIsBlockDownloadComplete() {
+        return isBlockDownloadComplete.get();
+    }
+
+    public ReadOnlyBooleanProperty isBlockDownloadCompleteProperty() {
+        return isBlockDownloadComplete;
+    }
+
+    public boolean isHasSufficientPeersForBroadcast() {
+        return hasSufficientPeersForBroadcast.get();
+    }
+
+    public ReadOnlyBooleanProperty hasSufficientPeersForBroadcastProperty() {
+        return hasSufficientPeersForBroadcast;
+    }

These look unused. Am I missing something, 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4592#pullrequestreview-502018166
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20201005/8f9a7fa3/attachment.html>