[bisq-network/bisq] Add new getoffer(id) api method (#4598)

Stan notifications at github.com
Mon Oct 5 20:03:24 UTC 2020


There are a number of use cases where a CLI user may want to see a single offer instead of every offer for a currency pair on the buy or sell side.  The changes are:

- Add `getoffer` to `grpc.proto`
- Add new method to `GrpcOffersService`, `CoreApi`, `CoreOffersService`
- Add new method to CLI
- Adjust create offer tests to use this new convenience method
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/4598

-- Commit Summary --

  * Simplify GrpcOffersService#createOffer (refactor)
  * Fix method name
  * Use consumer::accept instead of a countdown latch
  * Add new getoffer(id) api method

-- File Changes --

    M apitest/src/test/java/bisq/apitest/method/MethodTest.java (11)
    M apitest/src/test/java/bisq/apitest/method/offer/AbstractCreateOfferTest.java (4)
    M apitest/src/test/java/bisq/apitest/method/offer/CreateOfferUsingFixedPriceTest.java (67)
    M apitest/src/test/java/bisq/apitest/method/offer/CreateOfferUsingMarketPriceMarginTest.java (88)
    M cli/src/main/java/bisq/cli/CliMain.java (17)
    M core/src/main/java/bisq/core/api/CoreApi.java (68)
    M core/src/main/java/bisq/core/api/CoreOffersService.java (85)
    M daemon/src/main/java/bisq/daemon/grpc/GrpcOffersService.java (28)
    M proto/src/main/proto/grpc.proto (10)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/4598.patch
https://github.com/bisq-network/bisq/pull/4598.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4598
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20201005/fb2d357d/attachment-0001.html>


More information about the bisq-github mailing list