[bisq-network/bisq] Improve bisq setup (#4592)

chimp1984 notifications at github.com
Mon Oct 5 20:39:08 UTC 2020


@chimp1984 commented on this pull request.



> +        walletsSetup.downloadPercentageProperty().addListener((observable, oldValue, newValue) -> {
+            if (walletsSetup.isDownloadComplete())
+                isBlockDownloadComplete.set(true);
+        });
+
+        walletsSetup.numPeersProperty().addListener((observable, oldValue, newValue) -> {
+            if (walletsSetup.hasSufficientPeersForBroadcast())
+                hasSufficientPeersForBroadcast.set(true);
+        });
+
+        p2pNetworkAndWalletInitialized = EasyBind.combine(updatedDataReceived,
+                isBlockDownloadComplete,
+                hasSufficientPeersForBroadcast,
+                allDomainServicesInitialized,
+                (a, b, c, d) -> {
+                    if (a && b && c) {

So far not but in future PRs it will be used. The allDomainServicesInitialized might disappear over time or only be used were we need a ordered initialisation, but I think that need to be delegated to the domain where it is used as we did with DaoStartup class. The listeners dont know about the order, but most domains should be independent anyway, and if not it is a sign that there is a parent domain which need to do the initialisation of its children. Of if not there that we miss such a parent daomain. 


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4592#discussion_r499858533
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20201005/721f19c8/attachment.html>


More information about the bisq-github mailing list