[bisq-network/bisq] Improve bisq setup (#4592)

chimp1984 notifications at github.com
Mon Oct 5 20:40:52 UTC 2020


@chimp1984 commented on this pull request.



> +    public boolean isWalletAndNetworkReady() {
+        return walletAndNetworkReady.get();
+    }
+
+    public ReadOnlyBooleanProperty walletAndNetworkReadyProperty() {
+        return walletAndNetworkReady;
+    }
+
+    public boolean isAllDomainServicesInitialized() {
+        return allDomainServicesInitialized.get();
+    }
+
+    public ReadOnlyBooleanProperty allDomainServicesInitializedProperty() {
+        return allDomainServicesInitialized;
+    }
+
+    public boolean isApplicationFullyInitialized() {
+        return applicationFullyInitialized.get();
+    }
+
+    public ReadOnlyBooleanProperty applicationFullyInitializedProperty() {
+        return applicationFullyInitialized;
+    }
+
+    public boolean isUpdatedDataReceived() {
+        return updatedDataReceived.get();
+    }
+
+    public ReadOnlyBooleanProperty updatedDataReceivedProperty() {
+        return updatedDataReceived;
+    }
+
+    public boolean isIsBlockDownloadComplete() {
+        return isBlockDownloadComplete.get();
+    }
+
+    public ReadOnlyBooleanProperty isBlockDownloadCompleteProperty() {
+        return isBlockDownloadComplete;
+    }
+
+    public boolean isHasSufficientPeersForBroadcast() {
+        return hasSufficientPeersForBroadcast.get();
+    }
+
+    public ReadOnlyBooleanProperty hasSufficientPeersForBroadcastProperty() {
+        return hasSufficientPeersForBroadcast;
+    }

Yes, they are there for future usage. Some might not be needed, once we have refactored it completely we might remove some, but better to have it in place now so we can start migrating. 
At the checks for when to start a domain specific init is duplicated in many places and often not correct. This PR should start to refactor those cases and avoid those issues.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4592#discussion_r499859395
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20201005/75d44e9e/attachment.html>


More information about the bisq-github mailing list