[bisq-network/bisq] Simplify GrpcOffersService#createOffer (refactor) (#4596)

[chimp1984]

@chimp1984 requested changes on this pull request.



> @@ -87,15 +88,16 @@ public CoreOffersService(CreateOfferService createOfferService,
     }
 
     // Create and place new offer.
-    Offer createOffer(String currencyCode,
-                      String directionAsString,
-                      String priceAsString,
-                      boolean useMarketBasedPrice,
-                      double marketPriceMargin,
-                      long amountAsLong,
-                      long minAmountAsLong,
-                      double buyerSecurityDeposit,
-                      String paymentAccountId) {
+    Offer createAndPlaceOffer(String currencyCode,

I think it would be more clear to not return the offer, as it is passed via the `Consumer<Offer> resultHandler`. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4596#pullrequestreview-502561749
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20201005/8dbb7d0b/attachment-0001.html>