[bisq-network/bisq] Simplify GrpcOffersService#createOffer (refactor) (#4596)
Stan
notifications at github.com
Tue Oct 6 14:22:23 UTC 2020
@ghubstan commented on this pull request.
> @@ -87,15 +88,16 @@ public CoreOffersService(CreateOfferService createOfferService,
}
// Create and place new offer.
- Offer createOffer(String currencyCode,
- String directionAsString,
- String priceAsString,
- boolean useMarketBasedPrice,
- double marketPriceMargin,
- long amountAsLong,
- long minAmountAsLong,
- double buyerSecurityDeposit,
- String paymentAccountId) {
+ Offer createAndPlaceOffer(String currencyCode,
Clever. Fix is in commit 30e6dae.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4596#discussion_r500326526
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20201006/ee88e7b8/attachment.html>
More information about the bisq-github
mailing list