[bisq-network/bisq] Re activate confirm buttons again (#4602)

[chimp1984]

Implements what we discussed in https://github.com/bisq-network/bisq/pull/4562

>     * Enable for buyer and altcoin seller at all times (only once arbitration is opened it is disabled as there is no way anyway to do a normal payout anymore.
> 
>     * Disable for fiat seller while mediation is open. Enable it at dispute result if no penalty was applied by mediators (derived from payout suggestion). So the mediator is the enabler for the confirm-button by his judgement expressed in the payout suggestion. This solves automatically point 2 as if the mediated payout suggestion is the same as the happy-path there is no avoid-penalty issue as no penalty was applied.
>       If seller confirms receipt in mediation the mediator can close anyway so there is only a bit of extra friction and delay due the communication but the dispute has to be closed anyway from the mediator. So I don't see that this creates any significant difference. If mediator has applied a penalty to the buyer the seller still gets his button activated (no penaly for seller - this is the only condition we check). So the seller has 2 options: accept mediated result and hope that buyer accept as well, or click confirm button and "forgive" buyer. The confirm button would stay active also after accept button has been clicked. So he can try mediated suggestion and before it goes to arbitration click the confirm button so we avoid arbitration cases.


You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/4602

-- Commit Summary --

  * Add mediationResultAppliedPenaltyToSeller method to Trade
  * Refactor: Remove commented out code and comments
  * Move checks to enable confirm to Trade
  * Refactor: Move method

-- File Changes --

    M core/src/main/java/bisq/core/dao/monitoring/DaoStateMonitoringService.java (6)
    M core/src/main/java/bisq/core/trade/BuyerTrade.java (4)
    M core/src/main/java/bisq/core/trade/SellerTrade.java (30)
    M core/src/main/java/bisq/core/trade/Trade.java (29)
    M core/src/main/java/bisq/core/trade/protocol/BuyerProtocol.java (3)
    M core/src/main/java/bisq/core/trade/protocol/DisputeProtocol.java (4)
    M core/src/main/java/bisq/core/trade/protocol/SellerProtocol.java (3)
    M desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/steps/TradeStepView.java (8)
    M desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/steps/buyer/BuyerStep2View.java (22)
    M desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/steps/seller/SellerStep3View.java (27)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/4602.patch
https://github.com/bisq-network/bisq/pull/4602.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4602
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20201006/831e31ee/attachment-0001.html>