[bisq-network/bisq] Adjust numbers alignment (#4171)

[cd2357]

> I'm of the preference of keeping the 'Amount' column alignment consistent with the rest more than keeping the commas aligned.

I agree with @freimair on this, right-aligning for numeric values makes them more readable because of the comma alignment. [Bitfinex](https://www.bitfinex.com/trading) and [Kraken](https://trade.kraken.com/charts) dashboards right-align them as well.

The [material design guidelines](https://material.io/components/data-tables) also default to text as left-aligned, numbers as right-aligned.

> ..the last column centered if its a column with check boxes..

Here I agree with @pedromvpg , checkbox columns look better when center-aligned.

Also text columns should probably stay left-aligned, as @pedromvpg suggested (for consistency with the rest of the UI). This PR, in the current form, also changes this (for example, Offer ID becomes right-aligned, even though its not a numeric value).

---

>From what I can tell, the main point of this PR was the numeric alignment. So to simplify the decision, let's just concentrate on this one aspect (and leave all else unchanged, like text left-aligned, checkboxes center-aligned).

It seems there are strong pros and cons for left and right aligning numbers.

Maybe @m52go could run a user survey on twitter, and ask them to vote between

A) left-aligned number columns

<img width="820" alt="Screenshot 2020-10-07 at 12 24 00" src="https://user-images.githubusercontent.com/15956136/95319845-d2d29780-0898-11eb-8b5f-5927a92dda45.png">

B) right-aligned number columns

<img width="823" alt="Screenshot 2020-10-07 at 12 22 22" src="https://user-images.githubusercontent.com/15956136/95319858-d7974b80-0898-11eb-87f5-9ba2f5fbcfcb.png">

Or maybe there's another, better way to get user feedback?

Would this make sense?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4171#issuecomment-704856255
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20201007/e877feaf/attachment.html>