[bisq-network/bisq] Add new 'getoffer offer-id' api method (#4608)
Stan
notifications at github.com
Wed Oct 7 15:12:42 UTC 2020
There are a number of use cases where a user may want to see a single offer instead of every offer for a currency pair on the buy or sell side. The changes are:
- Add getoffer to grpc.proto
- Add new method to GrpcOffersService, CoreApi, CoreOffersService
- Add new method to CLI
- Adjust create offer tests to use this new convenience
You can view, comment on, or merge this pull request online at:
https://github.com/bisq-network/bisq/pull/4608
-- Commit Summary --
* Add new 'getoffer offer-id' api method
-- File Changes --
M apitest/src/test/java/bisq/apitest/method/MethodTest.java (11)
M apitest/src/test/java/bisq/apitest/method/offer/AbstractCreateOfferTest.java (4)
M apitest/src/test/java/bisq/apitest/method/offer/CreateOfferUsingFixedPriceTest.java (67)
M apitest/src/test/java/bisq/apitest/method/offer/CreateOfferUsingMarketPriceMarginTest.java (88)
M apitest/src/test/java/bisq/apitest/method/offer/ValidateCreateOfferTest.java (1)
M cli/src/main/java/bisq/cli/CliMain.java (16)
M core/src/main/java/bisq/core/api/CoreApi.java (4)
M core/src/main/java/bisq/core/api/CoreOffersService.java (11)
M daemon/src/main/java/bisq/daemon/grpc/GrpcOffersService.java (13)
M proto/src/main/proto/grpc.proto (9)
-- Patch Links --
https://github.com/bisq-network/bisq/pull/4608.patch
https://github.com/bisq-network/bisq/pull/4608.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4608
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20201007/7c052ce7/attachment.html>
More information about the bisq-github
mailing list