[bisq-network/bisq] Setting jvm option `-Djdk.module.illegalAccess=deny` (#4600)

[cd2357]

FYI: this may work well with Java 10 and the current JavaFX, but it caused issues with guice in #4242 when the packaged app contains more recent JREs (tested with Java 11, 14 and 15).

More specifically, when opening the packaged app:
- when it was packaged with this flag: starting the app just opened an empty window (with no contents whatsoever) + logs contained guice and illegal reflection exceptions
- when it was packaged without this flag: UI worked as expected

So for now I disabled it in the new jpackage script used in #4242 with https://github.com/bisq-network/bisq/pull/4242/commits/696a788e5edcbca883c3546c36c997e6459b482c.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4600#issuecomment-705515616
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20201008/c519b55b/attachment.html>