[bisq-network/bisq] [WIP] Segwit for the trade protocol (#4612)

[Oscar Guindzberg]

<!-- 
- make yourself familiar with the CONTRIBUTING.md if you have not already (https://github.com/bisq-network/bisq/blob/master/CONTRIBUTING.md)
- make sure you follow our [coding style guidelines][https://github.com/bisq-network/style/issues)
- pick a descriptive title
- provide some meaningful PR description below
- create the PR
- in case you receive a "Change request" and/or a NACK, please react within 30 days. If not, we will close your PR and it can not be up for compensation.
- After addressing the change request, __please re-request a review!__ Otherwise we might miss your PR as we tend to only look at pull requests tagged with a "review required".
-->

Fixes #replaceWithIssueNr, fixes #replaceWithIssueNr

Your PR description here.

You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/4612

-- Commit Summary --

  * Segwit for the trade protocol start
  * Use local bitcoinj
  * Add constant SEGWIT_TRADE_PROTOCOL_ACTIVE
  * Add Capability.TRADE_PROTOCOL_SEGWIT
  * Trade protocol documentation
  * WIP Review TradeWalletService
  * Disable timeouts for local debugging
  * Use segwit addresses - to be reviewed if backwards compatibility needed
  * BtcWalletService: make segwit a variable
  * Revert "Validate AddressEntry.segwit"
  * Revert "Make it clear segwit is not used for the trade protocol yet."
  * Revert "Construct dummy outputs with LegacyAddress"
  * Revert "Switch back to LegacyAddress for fee estimation"
  * Serialize bitcoin tx with segwit data
  * Use p2wsh
  * Use p2wsh
  * Emergency publish payout tx: select segwit from the UI
  * Create the scriptCode the right way
  * Accept empty scriptSig in P2WPKH
  * Replace TradeWalletService.getInput() by reading output value
  * Use P2WPKH for trade protocol only is activated
  * Revert to bitcoinSerialize(false) in RawTransactionInput
  * Remove unused imports
  * TransactionWitness.redeemP2WSH() now receives a Script

-- File Changes --

    M build.gradle (7)
    M common/src/main/java/bisq/common/app/Capability.java (3)
    M common/src/main/java/bisq/common/config/Config.java (2)
    M core/src/main/java/bisq/core/app/WalletAppSetup.java (2)
    M core/src/main/java/bisq/core/btc/model/AddressEntry.java (4)
    M core/src/main/java/bisq/core/btc/wallet/BtcWalletService.java (14)
    M core/src/main/java/bisq/core/btc/wallet/TradeWalletService.java (197)
    M core/src/main/java/bisq/core/btc/wallet/WalletService.java (7)
    M core/src/main/java/bisq/core/trade/protocol/tasks/buyer/BuyerSignsDelayedPayoutTx.java (8)
    M core/src/main/java/bisq/core/trade/protocol/tasks/seller/SellerSignsDelayedPayoutTx.java (7)
    M desktop/src/main/java/bisq/desktop/main/overlays/windows/ManualPayoutTxWindow.java (8)
    A docs/trade-protocol.md (81)
    M gradle/witness/gradle-witness.gradle (2)
    M p2p/src/main/java/bisq/network/p2p/network/Connection.java (2)
    M p2p/src/main/java/bisq/network/p2p/network/NetworkNode.java (2)
    A segwitForTheTradeProtocl.txt (1)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/4612.patch
https://github.com/bisq-network/bisq/pull/4612.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4612
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20201009/ecb17424/attachment.html>