[bisq-network/bisq] If there are links in popups add a clickable foot note (#4623)

chimp1984 notifications at github.com
Sun Oct 11 21:33:09 UTC 2020


<!--
   SUPPORT REQUESTS: This is for reporting bugs in the Bisq app.
   If you have a support request, please join #support on Bisq's
   Keybase team at https://keybase.io/team/Bisq
-->

### Description

We often refer to the docs page or wiki for further information in popups but the links are plain text and not clickable.

### Steps to reproduce

Make XMR account, at safe you see a popup.

### Expected behaviour

Some way to click the link.

### Actual behaviour

Links are plain text and not clickable

### Screenshots

<img width="911" alt="Screen Shot 2020-10-11 at 16 23 58" src="https://user-images.githubusercontent.com/54558767/95690573-69c38a80-0bde-11eb-87fe-389694f98870.png">

#### Additional info

The text component we use for popups does not support html text. We do not want to add webkit just to enable html text, that is too much of a performance and dependency tag. We could look out for some 3rd party component which supports a simple markdown format supporting links but we looked into that option in the past and there was no satisfying solution.

Recommended solution:
Add a marker to the links in the text (e.g. [1] ) and a footer with reference and a clickable link. This can be a one liner component with hyperlink functionality as we use in several places.
If there is only one link we could also add a button for opening the link, but the footer reference solution seems more scalable and could be added in a micro-framework way so that it is easy to re-use. 


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/4623
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20201011/b2c3985d/attachment-0001.html>


More information about the bisq-github mailing list