[bisq-network/bisq] Fix send non bsq funds (#4632)

[Oscar Guindzberg]

<!-- 
- make yourself familiar with the CONTRIBUTING.md if you have not already (https://github.com/bisq-network/bisq/blob/master/CONTRIBUTING.md)
- make sure you follow our [coding style guidelines][https://github.com/bisq-network/style/issues)
- pick a descriptive title
- provide some meaningful PR description below
- create the PR
- in case you receive a "Change request" and/or a NACK, please react within 30 days. If not, we will close your PR and it can not be up for compensation.
- After addressing the change request, __please re-request a review!__ Otherwise we might miss your PR as we tend to only look at pull requests tagged with a "review required".
-->

Fixes a bug sending non-BSQ funds from the BSQ wallet: If the destination address is segwit, an exception is thrown:

org.bitcoinj.core.AddressFormatException$InvalidCharacter: Invalid character '0' at position 17
     at org.bitcoinj.core.Base58.decode(Base58.java:132)
     at org.bitcoinj.core.Base58.decodeChecked(Base58.java:171)
     at org.bitcoinj.core.LegacyAddress.fromBase58(LegacyAddress.java:146)
     at bisq.core.btc.wallet.BsqWalletService.getPreparedSendTx(BsqWalletService.java:534)
     at bisq.core.btc.wallet.BsqWalletService.getPreparedSendBtcTx(BsqWalletService.java:525)
     at bisq.desktop.main.dao.wallet.send.BsqSendView.lambda$addSendBtcGroup$6(BsqSendView.java:300)
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/4632

-- Commit Summary --

  * Accept segwit addresses when sending non-BSQ funds.

-- File Changes --

    M core/src/main/java/bisq/core/btc/wallet/BsqWalletService.java (2)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/4632.patch
https://github.com/bisq-network/bisq/pull/4632.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4632
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20201012/da7481e8/attachment.html>