[bisq-network/bisq] Make URLs in popup notices clickable (#4637)

[James Cox]

Fixes #4623

URLs in Javafx label controls are not clickable, so separate them out to one or more clickable Hyperlinks displayed at the footer of the popup.

The approach taken for this is to embed the tag `[HYPERLINK]` in the message before a link that you want to be handled this way.  The links should be at the end of the popup message, in the same order that they will be displayed.  Using the tag has the advantage of being optional, and does not require new code to be written for each individual popup.


These popup messages have been modified to use the [HYPERLINK] tag:

- offerbook.warning.newVersionAnnouncement
- offerbook.warning.requireUpdateToNewVersion
- portfolio.pending.invalidDelayedPayoutTx (2 hyperlinks)
- portfolio.pending.step2_buyer.confirmStart.proof.noneProvided
- portfolio.pending.openAgainDispute.msg
- portfolio.pending.mediationResult.popup.info
- portfolio.pending.mediationResult.popup.selfAccepted.lockTimeOver
- portfolio.pending.failedTrade.missingDepositTx
- portfolio.pending.failedTrade.buyer.existingDepositTxButMissingDelayedPayoutTx
- portfolio.pending.failedTrade.seller.existingDepositTxButMissingDelayedPayoutTx
- portfolio.pending.failedTrade.errorMsgSet
- portfolio.pending.failedTrade.missingContract
- settings.net.warn.usePublicNodes
- setting.info.msg
- account.altcoin.popup.xmr.msg (2 hyperlinks)
- account.seed.backup.warning
- displayUpdateDownloadWindow.download.failed
- displayUpdateDownloadWindow.installer.failed
- displayUpdateDownloadWindow.verify.failed
- torNetworkSettingWindow.bridges.info
- popup.reportError
- popup.warning.incompatibleDB
- popup.warning.trade.depositTxNull (2 hyperlinks)
- popup.info.qubesOSSetupInfo
- popup.accountSigning.generalInformation
- payment.clearXchange.info
- payment.limits.info.withSigning
- payment.f2f.info


### Examples:


![bisq-account-altcoin-popup-xmr](https://user-images.githubusercontent.com/47253594/95870500-2c701180-0d32-11eb-8ecf-fe16dd05d65e.png)

![bisq-setting-info-msg](https://user-images.githubusercontent.com/47253594/95870533-37c33d00-0d32-11eb-92fd-f070cedb828a.png)

![bisq-payment-clearXchange-info](https://user-images.githubusercontent.com/47253594/95870558-3e51b480-0d32-11eb-9528-bfe9df44df8a.png)

You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/4637

-- Commit Summary --

  * Make URLs in popup notices clickable

-- File Changes --

    M core/src/main/resources/i18n/displayStrings.properties (123)
    M desktop/src/main/java/bisq/desktop/main/overlays/Overlay.java (64)
    M desktop/src/main/java/bisq/desktop/util/GUIUtil.java (4)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/4637.patch
https://github.com/bisq-network/bisq/pull/4637.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4637
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20201013/0d3f94ae/attachment.html>