[bisq-network/bisq] Make URLs in popup notices clickable (#4637)

James Cox notifications at github.com
Wed Oct 14 18:46:22 UTC 2020


**Status update**: testing revealed some of the more complex popups (e.g. missingDepositTx) were not compatible with the first implementation of this feature.  So I re-implemented the parsing to extract hyperlinks from anywhere within the textual message using regex Pattern/Matcher and String.replaceFirst.

The code has been fully retested as documented [here](https://github.com/bisq-network/bisq/pull/4637#issuecomment-708144012) and is ready for review.  (Apologies to those who already reviewed the prior version).

**N.B.** I came across a message which appears unused in Bisq: `popup.warning.trade.depositTxNull`.  Could someone confirm that?  Maybe it should be removed from displayStrings.properties now.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4637#issuecomment-708591232
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20201014/b0b73dea/attachment-0001.html>


More information about the bisq-github mailing list