[bisq-network/bisq] Delayed payout tx is not providing tx confidence (#4650)

[Oscar Guindzberg]

The bitcoinj wallet is interested in txs sending funds to/from one of the wallet addresses.
The trade p2sh-multisig address is not part of the wallet (even you do kind of a hack by taking one of the wallet keys to creating the p2sh-multisig address).
I don't know how the delayed payout tx gets into the wallet (you add it manually?)... probably the wallet ignores the tx because Wallet.isTransactionRelevant(tx) returns false.
Probably bloom filters are not updated to be notified of txs sending to/from the p2sh-multisig address.
You may ask why the problem does not happen in normal "payout tx"s? because they send funds to one of the wallet addresses.


How to solve it.

You have to get the bloom filters updated.
One way of doing it is by using the wallet's watched addresses feature. See Wallet.addWatchedAddress(). You can use that to add the p2sh-multisig address. I think that may affect the wallet balance and coin selection for changing, so I am not sure that is a good idea.
You could create a new wallet just with a watched p2sh-multisig address.
Or you can update manually the bloom filter somehow to include the p2sh-multisig address or the burningman address.
There is also the MarriedKeyChain class that also deals with p2sh-multisig, but that is not the place to look at... just telling to avoid doing useless research there.
In any case, the bisq btc wallet is not interested in the delayed payout tx, so maybe you would have to keep the tx out of that wallet and deal with updating confirmation status by other means.

I am talking from the top of my head, so consider everything I wrote as "things to evaluate".

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/4650#issuecomment-709373901
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20201015/156fded1/attachment.html>