[bisq-network/bisq] Handle Capabilities for encrypted messages (offer availibility request/response) (#4659)

chimp1984 notifications at github.com
Fri Oct 16 16:08:47 UTC 2020


We did check in Connection for SupportedCapabilitiesMessage and if a message is of that type we set the capability.
But encrypted messages are wrapped in a PrefixedSealedAndSignedMessage so the payload is not visible as SupportedCapabilitiesMessage without decrypting it.
We need to call maybeHandleSupportedCapabilitiesMessage at decrypting the message. We do that only for direct messages not for mailbox messages as we likely do not have a connection open to the peer in that case (otherwise it would not be a mailbox msg) and as we don't have the connection available (we get is as AddDataMessage broadcast from an peer, so could could not apply it to the Connection of the sender.
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/4659

-- Commit Summary --

  * Handle Capabilities for encrypted messages (offer availibility request/response)

-- File Changes --

    M p2p/src/main/java/bisq/network/p2p/P2PService.java (1)
    M p2p/src/main/java/bisq/network/p2p/network/Connection.java (14)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/4659.patch
https://github.com/bisq-network/bisq/pull/4659.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4659
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20201016/0eedfd68/attachment.html>


More information about the bisq-github mailing list