[bisq-network/bisq] Fix trade protocol check for refund agent ticket close (#4615)
Christoph Atteneder
notifications at github.com
Mon Oct 19 08:27:33 UTC 2020
@ripcurlx commented on this pull request.
> @@ -84,4 +86,17 @@ protected SupportType getType() {
protected DisputeSession getConcreteDisputeChatSession(Dispute dispute) {
return new ArbitrationSession(dispute, disputeManager.isTrader(dispute));
}
+
+ @Override
+ protected void onCloseDispute(Dispute dispute) {
+ long protocolVersion = dispute.getContract().getOfferPayload().getProtocolVersion();
+ // Only cases with protocolVersion 1 are candidates for legacy arbitration.
+ // This code path is not tested and it is not assumed that it is still be used as old arbitrators would use
+ // their old Bisq version if sill cases are pending.
NIT: `sill` instead of `still`
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4615#pullrequestreview-511522904
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20201019/1300931f/attachment.html>
More information about the bisq-github
mailing list