[bisq-network/bisq] Add 'confirmpaymentreceived' api method (#4669)

[Stan]

Add '`confirmpaymentreceived`' api method

- Add `ConfirmPaymentReceived` rpc to grpc.proto.

- Add new method to `GrpcTradesService`, `CoreTradesService`, `CoreApi`, & `CliMain`.

- Add new test case.

- `TakeOfferDataModel` uses recently added `paymentAccount.isHalCashAccount()`.


PR https://github.com/bisq-network/bisq/pull/4668 needs to be reviewed and merged before this one.

You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/4669

-- Commit Summary --

  * Refactor OfferUtil into an injected service
  * Reformat, tidy up OfferUtil
  * Add license comment, reformat CoinUtilTest
  * Reformat desktop createoffer view & data model tests
  * Reformat desktop EditOfferDataModelTest
  * Resolve argument reassignment issue (found by codacy)
  * Remove unused final fields (found by codacy)
  * Move utility logic from desktop offer models to OfferUtil
  * Remove unused fields and imports
  * Add 'takeoffer' api method
  * Remove unused field
  * Remove default constructors for codacy
  * Add 'confirmpaymentsent' api method
  * Add 'confirmpaymentreceived' api method

-- File Changes --

    M apitest/src/test/java/bisq/apitest/ApiTestCase.java (7)
    M apitest/src/test/java/bisq/apitest/method/MethodTest.java (36)
    R apitest/src/test/java/bisq/apitest/method/offer/AbstractOfferTest.java (65)
    M apitest/src/test/java/bisq/apitest/method/offer/CreateOfferUsingFixedPriceTest.java (2)
    M apitest/src/test/java/bisq/apitest/method/offer/CreateOfferUsingMarketPriceMarginTest.java (2)
    M apitest/src/test/java/bisq/apitest/method/offer/ValidateCreateOfferTest.java (2)
    A apitest/src/test/java/bisq/apitest/method/trade/AbstractTradeTest.java (32)
    A apitest/src/test/java/bisq/apitest/method/trade/TakeBuyBTCOfferTest.java (129)
    A apitest/src/test/java/bisq/apitest/method/trade/TakeSellBTCOfferTest.java (131)
    M cli/src/main/java/bisq/cli/CliMain.java (50)
    M cli/src/main/java/bisq/cli/GrpcStubs.java (3)
    M core/src/main/java/bisq/core/api/CoreApi.java (31)
    A core/src/main/java/bisq/core/api/CoreTradesService.java (132)
    M core/src/main/java/bisq/core/api/model/OfferInfo.java (44)
    A core/src/main/java/bisq/core/api/model/TradeInfo.java (211)
    M core/src/main/java/bisq/core/btc/wallet/TradeWalletService.java (5)
    M core/src/main/java/bisq/core/offer/CreateOfferService.java (37)
    D core/src/main/java/bisq/core/offer/MakerFeeProvider.java (29)
    M core/src/main/java/bisq/core/offer/Offer.java (5)
    M core/src/main/java/bisq/core/offer/OfferUtil.java (401)
    A core/src/main/java/bisq/core/offer/takeoffer/TakeOfferModel.java (293)
    M core/src/main/java/bisq/core/payment/PaymentAccount.java (24)
    M core/src/main/java/bisq/core/trade/Contract.java (6)
    M core/src/main/java/bisq/core/trade/Trade.java (6)
    M core/src/main/java/bisq/core/trade/statistics/TradeStatistics2.java (4)
    A core/src/main/java/bisq/core/util/VolumeUtil.java (50)
    M core/src/main/java/bisq/core/util/coin/CoinUtil.java (109)
    D core/src/test/java/bisq/core/util/CoinCryptoUtilsTest.java (60)
    R core/src/test/java/bisq/core/util/coin/CoinUtilTest.java (56)
    M daemon/src/main/java/bisq/daemon/grpc/GrpcOffersService.java (29)
    M daemon/src/main/java/bisq/daemon/grpc/GrpcServer.java (4)
    A daemon/src/main/java/bisq/daemon/grpc/GrpcTradesService.java (121)
    D desktop/src/main/java/bisq/desktop/main/offer/MakerFeeProvider.java (13)
    M desktop/src/main/java/bisq/desktop/main/offer/MutableOfferDataModel.java (94)
    M desktop/src/main/java/bisq/desktop/main/offer/MutableOfferView.java (2)
    M desktop/src/main/java/bisq/desktop/main/offer/MutableOfferViewModel.java (31)
    M desktop/src/main/java/bisq/desktop/main/offer/OfferDataModel.java (26)
    M desktop/src/main/java/bisq/desktop/main/offer/createoffer/CreateOfferDataModel.java (6)
    M desktop/src/main/java/bisq/desktop/main/offer/createoffer/CreateOfferViewModel.java (6)
    M desktop/src/main/java/bisq/desktop/main/offer/offerbook/OfferBook.java (7)
    M desktop/src/main/java/bisq/desktop/main/offer/takeoffer/TakeOfferDataModel.java (24)
    M desktop/src/main/java/bisq/desktop/main/offer/takeoffer/TakeOfferViewModel.java (33)
    M desktop/src/main/java/bisq/desktop/main/portfolio/editoffer/EditOfferDataModel.java (6)
    M desktop/src/main/java/bisq/desktop/main/portfolio/editoffer/EditOfferViewModel.java (6)
    M desktop/src/test/java/bisq/desktop/main/offer/createoffer/CreateOfferDataModelTest.java (36)
    M desktop/src/test/java/bisq/desktop/main/offer/createoffer/CreateOfferViewModelTest.java (44)
    M desktop/src/test/java/bisq/desktop/main/portfolio/editoffer/EditOfferDataModelTest.java (29)
    M proto/src/main/proto/grpc.proto (65)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/4669.patch
https://github.com/bisq-network/bisq/pull/4669.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4669
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20201019/78b6a890/attachment-0001.html>