[bisq-network/bisq] Update/refresh displayString.properties (#4671)

m52go notifications at github.com
Wed Oct 21 05:24:16 UTC 2020


@m52go commented on this pull request.

Good improvements—all small suggestions.

> @@ -3006,12 +3006,12 @@ password.deriveKey=Derive key from password
 password.walletDecrypted=Wallet successfully decrypted and password protection removed.
 password.wrongPw=You entered the wrong password.\n\nPlease try entering your password again, carefully checking for typos or spelling errors.
 password.walletEncrypted=Wallet successfully encrypted and password protection enabled.
-password.walletEncryptionFailed=Wallet password could not be set. You might have imported seed words which are not matching the wallet database. Please contact the developers on the Bisq Forum.
+password.walletEncryptionFailed=Wallet password could not be set. You may have imported seed words which do not match the wallet database. Please contact the developers on Keybase - 'https://keybase.io/team/bisq' .

```suggestion
password.walletEncryptionFailed=Wallet password could not be set. You may have imported seed words which do not match the wallet database. Please contact the developers on Keybase (https://keybase.io/team/bisq).
```
I don't like the quotes, but this might be subjective.

>  password.passwordsDoNotMatch=The 2 passwords you entered don't match.
 password.forgotPassword=Forgot password?
 password.backupReminder=Please note that when setting a wallet password all automatically created backups from the unencrypted wallet will be deleted.\n\n\
-  It is highly recommended to make a backup of the application directory and write down your seed words before setting a password!
-password.backupWasDone=I have already done a backup
+  It is highly recommended that you make a backup of the application directory and to write down your seed words before setting a password!

```suggestion
  It is highly recommended that you make a backup of the application directory and write down your seed words before setting a password!
```

> @@ -3024,7 +3024,7 @@ You must empty this wallet before attempting to restore an older one, as mixing
 together can lead to invalidated backups.\n\n\
 Please finalize your trades, close all your open offers and go to the Funds section to withdraw your bitcoin.\n\
 In case you cannot access your bitcoin you can use the emergency tool to empty the wallet.\n\
-To open that emergency tool press \"alt + e\" or \"option + e\" .
+To open that emergency tool press \"Alt + e\" or \"Ctrl + e\" or \"Cmd + e\" .

```suggestion
To open the emergency tool press \"Alt+e\" or \"Cmd/Ctrl+e\".
```
To be consistent with the way key shortcuts have been written elsewhere (not entirely consistent yet, but would like to make it that way).

> @@ -3215,8 +3215,8 @@ payment.f2f.info='Face to Face' trades have different rules and come with differ
   ● The trading peers need to bring their laptops and do the confirmation of 'payment sent' and 'payment received' at the meeting place.\n\
   ● If a maker has special 'terms and conditions' they must state those in the 'Additional information' text field in the account.\n\
   ● By taking an offer the taker agrees to the maker's stated 'terms and conditions'.\n\
-  ● In case of a dispute the mediator or arbitrator cannot help much as it is usually hard to get tamper proof evidence of what \
-  happened at the meeting. In such cases the BTC funds might get locked indefinitely or until the trading peers come to \
+  ● In case of a dispute the mediator or arbitrator cannot be of much assistance as it is usually difficult to get tamper proof evidence \

```suggestion
  ● In case of a dispute the mediator or arbitrator cannot be of much assistance as it is usually difficult to get tamper-proof evidence \
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4671#pullrequestreview-513312127
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20201020/f528b247/attachment.html>


More information about the bisq-github mailing list