[bisq-network/bisq] Refactor offer/trade related classes in core and desktop (#4672)

sqrrm notifications at github.com
Wed Oct 21 14:25:16 UTC 2020


@sqrrm commented on this pull request.

One minor comment. I think it's otherwise good.

To make it easier to review, it helps to keep refactorings separated in different commits. In particular pure refactor work and minor improvements are very helpful when kept separate.

> +    private final Predicate<ObjectProperty<Coin>> isPositiveAmount = (c) -> c.get() != null && !c.get().isZero();
+    private final Predicate<ObjectProperty<Price>> isPositivePrice = (p) -> p.get() != null && !p.get().isZero();
+    private final Predicate<ObjectProperty<Volume>> isPositiveVolume = (v) -> v.get() != null && !v.get().isZero();

Shouldn't these be `isNonZero...`?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4672#pullrequestreview-513727007
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20201021/4c45b865/attachment.html>


More information about the bisq-github mailing list