[bisq-network/bisq] Refactor offer/trade related classes in core and desktop (#4672)

Stan notifications at github.com
Wed Oct 21 15:23:35 UTC 2020


@ghubstan commented on this pull request.



> -
-    public long getMaxTradeLimit(PaymentAccount paymentAccount,
-                                 String currencyCode,
-                                 OfferPayload.Direction direction) {
-        if (paymentAccount != null) {
-            return accountAgeWitnessService.getMyTradeLimit(paymentAccount, currencyCode, direction);
-        } else {
-            return 0;
-        }
-    }
-
-    public boolean isBuyOffer(OfferPayload.Direction direction) {
-        return OfferUtil.isBuyOffer(direction);
-    }
-
-

3 methods above were moved to OfferUtil.
(test -- can I add inline comment to my own pr?)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4672#pullrequestreview-513810833
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20201021/8e60a0fd/attachment-0001.html>


More information about the bisq-github mailing list