[bisq-network/bisq] Refactor offer/trade related classes in core and desktop (#4672)

[Stan]

@ghubstan commented on this pull request.



> +    private final Predicate<ObjectProperty<Coin>> isPositiveAmount = (c) -> c.get() != null && !c.get().isZero();
+    private final Predicate<ObjectProperty<Price>> isPositivePrice = (p) -> p.get() != null && !p.get().isZero();
+    private final Predicate<ObjectProperty<Volume>> isPositiveVolume = (v) -> v.get() != null && !v.get().isZero();

Fixed in 2ae6bfa, sub branch [5-suggested-changes](https://github.com/ghubstan/bisq/tree/5-suggested-changes).  Fixes for this PR will go into a separate PR.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4672#discussion_r509409425
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20201021/0f9ae872/attachment.html>