[bisq-network/bisq] [Draft] Changes suggested in PRs 4672,4673,4674,4675 (#4679)

Stan notifications at github.com
Wed Oct 21 17:17:04 UTC 2020


This PR includes changes suggested during review of PR chain https://github.com/bisq-network/bisq/pull/4672 ->  https://github.com/bisq-network/bisq/pull/4673 ->  https://github.com/bisq-network/bisq/pull/4674 ->  https://github.com/bisq-network/bisq/pull/4675.

Changes requested in those PRs are made here.





You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/4679

-- Commit Summary --

  * Refactor offer/trade related classes in core and desktop
  * Add 'takeoffer' API method
  * Add 'confirmpaymentsent' api method
  * Add 'confirmpaymentreceived' api method
  * Change predicate names isPositiveXYZ -> isNonZeroXYZ

-- File Changes --

    M apitest/src/test/java/bisq/apitest/ApiTestCase.java (7)
    M apitest/src/test/java/bisq/apitest/method/MethodTest.java (36)
    R apitest/src/test/java/bisq/apitest/method/offer/AbstractOfferTest.java (65)
    M apitest/src/test/java/bisq/apitest/method/offer/CreateOfferUsingFixedPriceTest.java (2)
    M apitest/src/test/java/bisq/apitest/method/offer/CreateOfferUsingMarketPriceMarginTest.java (2)
    M apitest/src/test/java/bisq/apitest/method/offer/ValidateCreateOfferTest.java (2)
    A apitest/src/test/java/bisq/apitest/method/trade/AbstractTradeTest.java (32)
    A apitest/src/test/java/bisq/apitest/method/trade/TakeBuyBTCOfferTest.java (129)
    A apitest/src/test/java/bisq/apitest/method/trade/TakeSellBTCOfferTest.java (131)
    M cli/src/main/java/bisq/cli/CliMain.java (50)
    M cli/src/main/java/bisq/cli/GrpcStubs.java (3)
    M core/src/main/java/bisq/core/api/CoreApi.java (31)
    A core/src/main/java/bisq/core/api/CoreTradesService.java (128)
    M core/src/main/java/bisq/core/api/model/OfferInfo.java (44)
    A core/src/main/java/bisq/core/api/model/TradeInfo.java (211)
    M core/src/main/java/bisq/core/offer/CreateOfferService.java (84)
    D core/src/main/java/bisq/core/offer/MakerFeeProvider.java (29)
    M core/src/main/java/bisq/core/offer/Offer.java (9)
    M core/src/main/java/bisq/core/offer/OfferUtil.java (408)
    A core/src/main/java/bisq/core/offer/takeoffer/TakeOfferModel.java (293)
    M core/src/main/java/bisq/core/payment/PaymentAccount.java (27)
    M core/src/main/java/bisq/core/trade/Contract.java (6)
    M core/src/main/java/bisq/core/trade/Trade.java (34)
    M core/src/main/java/bisq/core/trade/statistics/TradeStatistics2.java (4)
    M core/src/main/java/bisq/core/trade/statistics/TradeStatistics3.java (4)
    A core/src/main/java/bisq/core/util/VolumeUtil.java (50)
    M core/src/main/java/bisq/core/util/coin/CoinUtil.java (109)
    D core/src/test/java/bisq/core/util/CoinCryptoUtilsTest.java (60)
    R core/src/test/java/bisq/core/util/coin/CoinUtilTest.java (56)
    M daemon/src/main/java/bisq/daemon/grpc/GrpcOffersService.java (29)
    M daemon/src/main/java/bisq/daemon/grpc/GrpcServer.java (2)
    A daemon/src/main/java/bisq/daemon/grpc/GrpcTradesService.java (121)
    D desktop/src/main/java/bisq/desktop/main/offer/MakerFeeProvider.java (13)
    M desktop/src/main/java/bisq/desktop/main/offer/MutableOfferDataModel.java (88)
    M desktop/src/main/java/bisq/desktop/main/offer/MutableOfferView.java (2)
    M desktop/src/main/java/bisq/desktop/main/offer/MutableOfferViewModel.java (61)
    M desktop/src/main/java/bisq/desktop/main/offer/OfferDataModel.java (31)
    M desktop/src/main/java/bisq/desktop/main/offer/createoffer/CreateOfferDataModel.java (6)
    M desktop/src/main/java/bisq/desktop/main/offer/createoffer/CreateOfferViewModel.java (8)
    M desktop/src/main/java/bisq/desktop/main/offer/takeoffer/TakeOfferDataModel.java (21)
    M desktop/src/main/java/bisq/desktop/main/offer/takeoffer/TakeOfferViewModel.java (60)
    M desktop/src/main/java/bisq/desktop/main/portfolio/editoffer/EditOfferDataModel.java (7)
    M desktop/src/main/java/bisq/desktop/main/portfolio/editoffer/EditOfferViewModel.java (8)
    M desktop/src/test/java/bisq/desktop/main/offer/createoffer/CreateOfferDataModelTest.java (36)
    M desktop/src/test/java/bisq/desktop/main/offer/createoffer/CreateOfferViewModelTest.java (51)
    M desktop/src/test/java/bisq/desktop/main/portfolio/editoffer/EditOfferDataModelTest.java (29)
    M proto/src/main/proto/grpc.proto (64)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/4679.patch
https://github.com/bisq-network/bisq/pull/4679.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4679
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20201021/858f410d/attachment-0001.html>


More information about the bisq-github mailing list