[bisq-network/bisq] Use LegacyAddress instead of Address for BSQ (#4681)

Oscar Guindzberg notifications at github.com
Wed Oct 21 18:48:09 UTC 2020


<!-- 
- make yourself familiar with the CONTRIBUTING.md if you have not already (https://github.com/bisq-network/bisq/blob/master/CONTRIBUTING.md)
- make sure you follow our [coding style guidelines][https://github.com/bisq-network/style/issues)
- pick a descriptive title
- provide some meaningful PR description below
- create the PR
- in case you receive a "Change request" and/or a NACK, please react within 30 days. If not, we will close your PR and it can not be up for compensation.
- After addressing the change request, __please re-request a review!__ Otherwise we might miss your PR as we tend to only look at pull requests tagged with a "review required".
-->
Use LegacyAddress for BSQ related code to make sure we don't accept a segwit address for BSQ by accident.

You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/4681

-- Commit Summary --

  * Use LegacyAddress instead of Address for BSQ

-- File Changes --

    M core/src/main/java/bisq/core/btc/wallet/BsqWalletService.java (6)
    M core/src/main/java/bisq/core/dao/state/model/governance/CompensationProposal.java (1)
    M core/src/main/java/bisq/core/dao/state/model/governance/ReimbursementProposal.java (1)
    M core/src/main/java/bisq/core/util/coin/BsqFormatter.java (3)
    M desktop/src/main/java/bisq/desktop/main/dao/wallet/tx/BsqTxListItem.java (5)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/4681.patch
https://github.com/bisq-network/bisq/pull/4681.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4681
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20201021/bc092cd2/attachment.html>


More information about the bisq-github mailing list