[bisq-network/bisq] Add 'takeoffer' API method (#4673)

Stan notifications at github.com
Thu Oct 22 12:46:27 UTC 2020


@ghubstan commented on this pull request.



> +    @BeforeEach
+    public void init() {
+        alicesAccount = getDefaultPerfectDummyPaymentAccount(alicedaemon);
+        bobsAccount = getDefaultPerfectDummyPaymentAccount(bobdaemon);
+    }
+
+    @Test
+    @Order(1)
+    public void testTakeAlicesBuyOffer() {
+        try {
+            var alicesOffer = createAliceOffer(alicesAccount, "buy", "usd", 12500000);
+            var offerId = alicesOffer.getId();
+
+            // Wait for Alice's AddToOfferBook task.
+            // Wait times vary;  my logs show >= 2 second delay.
+            sleep(3000);

I think it's reach 6m already...
I don't see a way around it now, but over time, old, stable 'method' (or 'unit') test cases can be consolidated in 'scenario', then 'e2e' test cases, which would run them all in one test case.  That will help.   I was thinking of a dev/test cycle like this: a new feature/bug is tested in a method/unit test, then gradually moved to older scenario/e2e test cases.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4673#discussion_r510130833
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20201022/a4a30ff9/attachment.html>


More information about the bisq-github mailing list