[bisq-network/bisq] Add 'takeoffer' API method (#4673)

Stan notifications at github.com
Thu Oct 22 12:52:01 UTC 2020


@ghubstan commented on this pull request.



> +    Trade getTrade(String tradeId) {
+        return getTradeWithId(tradeId);
+    }
+
+    private Trade getTradeWithId(String tradeId) {
+        return tradeManager.getTradeById(tradeId).orElseThrow(() ->
+                new IllegalArgumentException(format("trade with id '%s' not found", tradeId)));
+    }

There's no need to split it, not sure why I did that.  I will change in https://github.com/bisq-network/bisq/pull/4679 (the tip of the PR/branch chain).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4673#discussion_r510134588
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20201022/3b507f99/attachment.html>


More information about the bisq-github mailing list