[bisq-network/bisq] Add 'takeoffer' API method (#4673)

sqrrm notifications at github.com
Thu Oct 22 13:06:50 UTC 2020


@sqrrm commented on this pull request.



> +    @BeforeEach
+    public void init() {
+        alicesAccount = getDefaultPerfectDummyPaymentAccount(alicedaemon);
+        bobsAccount = getDefaultPerfectDummyPaymentAccount(bobdaemon);
+    }
+
+    @Test
+    @Order(1)
+    public void testTakeAlicesBuyOffer() {
+        try {
+            var alicesOffer = createAliceOffer(alicesAccount, "buy", "usd", 12500000);
+            var offerId = alicesOffer.getId();
+
+            // Wait for Alice's AddToOfferBook task.
+            // Wait times vary;  my logs show >= 2 second delay.
+            sleep(3000);

Sounds like a plan. If the tests never run they're useless, so it's important that they can be run within a reasonable time frame. Might also be good with a consolidated scenario to find interdependency issues.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4673#discussion_r510145248
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20201022/58498208/attachment.html>


More information about the bisq-github mailing list