[bisq-network/bisq] [WIP] Segwit for the trade protocol (#4612)

[Oscar Guindzberg]

@oscarguindzberg commented on this pull request.



> @@ -1193,10 +1196,6 @@ private RawTransactionInput getRawInputFromTransactionInput(@NotNull Transaction
 
     private byte[] getMakersScriptSigProgram(TransactionInput transactionInput) throws TransactionVerificationException {
         byte[] scriptProgram = transactionInput.getScriptSig().getProgram();
-        if (scriptProgram.length == 0) {
-            throw new TransactionVerificationException("Inputs from maker not signed.");
-        }
-
         return scriptProgram;

This all started with scriptProgram.length == 0 being valid for a segwit input.
I just removed the method and moved its content to where it was being used, i.e. takerSignsDepositTx().
See takerSignsDepositTx():
```
                byte[] makersScriptSigProgram = makersInput.getScriptSig().getProgram();
                if (makersScriptSigProgram.length == 0 && TransactionWitness.EMPTY.equals(makersInput.getWitness())) {
                    throw new TransactionVerificationException("Inputs from maker not signed.");
                }
```
See https://github.com/bisq-network/bisq/pull/4612/commits/7eb808d2bf0af0b4b292ff44289459eaabcbcde4


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4612#discussion_r510205943
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20201022/3ac414e2/attachment.html>