[bisq-network/compensation] [WIP] For Cycle 18 (#688)

Stan notifications at github.com
Thu Oct 22 15:12:54 UTC 2020


## Summary

> _Specify the total amount of BSQ you are requesting, along with the USD total and BSQ/USD rate (don't include the brackets!):_

- **BSQ requested**: **`[BSQ amount]`** <!-- [BSQ amount] should be: USD amount / BSQ rate -->
- USD requested: [USD amount] <!-- [USD amount] should be: total of all contributions listed in "contributions delivered" table below -->
- BSQ rate: 0.68 USD per BSQ <!-- [rate] should be the rate used to determine the BSQ amount above, as specified in the cycle's rate announcement (https://bisq.wiki/Compensation_Maintainer#Announce_BSQ-USD_rate) -->
- Previous compensation request (if applicable): #658  <!-- Link to last compensation request submitted -->


## Contributions delivered

> _Add contributions you have [delivered](https://github.com/bisq-network/proposals/issues/19) and roles you have performed here as new rows in the table below. Role line-items should include an asterisk (*) in the team column._

| Title | Team | USD | Link | Notes |
| --- | --- | --- | --- | --- |
| Change 'createoffer' api method return type | dev | --- | https://github.com/bisq-network/bisq/pull/4554 | merged |
| Build out 'createoffer' API method | dev | --- | https://github.com/bisq-network/bisq/pull/4559 | merged |
| Tidy up CorePriceService (refactor) | dev | --- | https://github.com/bisq-network/bisq/pull/4594 | merged |
| Remove redundant DisputeAgentType enum | dev | --- | https://github.com/bisq-network/bisq/pull/4595 | merged |
| Simplify GrpcOffersService#createOffer (refactor) | dev | --- | https://github.com/bisq-network/bisq/pull/4596 | merged |
| Fix register dipute agent test assert | dev | 0 | https://github.com/bisq-network/bisq/pull/4605 | merged |
| Add new 'getoffer offer-id' api method | dev | --- | https://github.com/bisq-network/bisq/pull/4608 | merged |
| Refactor offer/trade related classes in core and desktop | dev | --- | https://github.com/bisq-network/bisq/pull/4672 | merged |
| Add 'takeoffer' API method | dev | --- | https://github.com/bisq-network/bisq/pull/4673 | merged |
| Add 'confirmpaymentsent' api method | dev | --- | https://github.com/bisq-network/bisq/pull/4674 | merged |
| Add 'confirmpaymentreceived' api method | dev | --- | https://github.com/bisq-network/bisq/pull/4675 | merged |
| Changes suggested in PRs 4672,4673,4674,4675 | dev | 0 | https://github.com/bisq-network/bisq/pull/4679 | merged |


<!-- 

Each contribution should be a new line-item in the table above. 

Title - optional, string.
Team - optional, must one of the following: admin, dev, growth, ops, support (case-insensitive). If the line-item is for a role, please add a `*`. See Example 2 below.
USD - optional, number. Please do not specify 'USD', as the column title makes units clear.
Link - optional, string.
Notes - optional, string.

Example 1 - typical contribution:

| Add local Bitcoin node configuration detection | dev | 240 | https://github.com/bisq-network/bisq/pull/3982

Example 2 - role (note the asterisk):

| Community manager | growth* | 400 | https://github.com/bisq-network/roles/issues/95#issuecomment-628431613

Example 3 - list of minor contributions, such as reviews:

| | | | https://github.com/bisq-network/bisq/pull/3968 | This and PRs below too small to be valued separately. See total at bottom.
| | | | https://github.com/bisq-network/bisq/pull/4040
| | | | https://github.com/bisq-network/bisq/pull/4044
| | | | https://github.com/bisq-network/bisq/pull/4048
| | | | https://github.com/bisq-network/bisq/pull/4066
| | dev | 400 | https://github.com/bisq-network/bisq/pull/4062 | Total for items above.

-->


## Contributions in progress

> _Provide links to work you're involved with that is still [in progress](https://github.com/bisq-network/proposals/issues/19). **This section is optional (the linter ignores it),** and is for your own benefit in keeping track of what you're doing and keeping other contributors up to date with the same._

| Title | Team | USD | Link | Notes |
| --- | --- | --- | --- | --- |
| Use existing timer in unlockwallet(pwd, timeout) | dev | --- | https://github.com/bisq-network/bisq/pull/4558 | awaiting review |
| Delete redundant core.api.StatusCheck | dev | --- | https://github.com/bisq-network/bisq/pull/4606 | will redo cleaner pr |

Also helped with release testing during this cycle.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/compensation/issues/688
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20201022/18a98ebc/attachment.html>


More information about the bisq-github mailing list