[bisq-network/bisq] [WIP] Segwit for the trade protocol (#4612)
Oscar Guindzberg
notifications at github.com
Thu Oct 22 17:23:27 UTC 2020
@oscarguindzberg commented on this pull request.
> @@ -1286,11 +1286,7 @@ private void signInput(Transaction transaction, TransactionInput input, int inpu
input.setScriptSig(ScriptBuilder.createInputScript(txSig, sigKey));
}
} else if (ScriptPattern.isP2WPKH(scriptPubKey)) {
- // TODO: Consider using this alternative way to build the scriptCode (taken from bitcoinj master)
- // Script scriptCode = ScriptBuilder.createP2PKHOutputScript(sigKey)
- Script scriptCode = new ScriptBuilder().data(
- ScriptBuilder.createOutputScript(LegacyAddress.fromKey(transaction.getParams(), sigKey)).getProgram())
- .build();
+ Script scriptCode = ScriptBuilder.createP2PKHOutputScript(sigKey);
done.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4612#discussion_r510332558
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20201022/e1dd5754/attachment.html>
More information about the bisq-github
mailing list