[bisq-network/bisq] Replace TradeUtils with singleton TradeUtil (#4697)

Stan notifications at github.com
Sat Oct 24 20:34:03 UTC 2020


The API is going to need some desktop trade utilities, which should be shared between `:desktop` and `:core.api`.   


The next PR in this chain will move trade related utilities in desktop model classes into this new singleton.

https://github.com/bisq-network/bisq/pull/4696 should be reviewed and merged before this one.

You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/4697

-- Commit Summary --

  * Block on tx-fee-request in core TakeOfferModel init
  * Add compiler warning suppression, remove comment
  * Add fields to grpc TradeInfo proto & wrapper
  * Replace static TradeUtil with singleton TradeUtil

-- File Changes --

    M core/src/main/java/bisq/core/api/model/OfferInfo.java (8)
    M core/src/main/java/bisq/core/api/model/TradeInfo.java (133)
    M core/src/main/java/bisq/core/offer/takeoffer/TakeOfferModel.java (38)
    M core/src/main/java/bisq/core/trade/TradeManager.java (5)
    R core/src/main/java/bisq/core/trade/TradeUtil.java (60)
    M core/src/main/java/bisq/core/trade/failed/FailedTradesManager.java (7)
    M proto/src/main/proto/grpc.proto (29)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/4697.patch
https://github.com/bisq-network/bisq/pull/4697.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4697
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20201024/fc64b060/attachment.html>


More information about the bisq-github mailing list