[bisq-network/bisq] Refactor PendingTradesViewModel methods -> TradeUtil & OfferUtil (#4699)

Stan notifications at github.com
Sun Oct 25 13:45:22 UTC 2020


PR https://github.com/bisq-network/bisq/pull/4697 should be reviewed & merged before this PR.
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/4699

-- Commit Summary --

  * Block on tx-fee-request in core TakeOfferModel init
  * Add compiler warning suppression, remove comment
  * Add fields to grpc TradeInfo proto & wrapper
  * Replace static TradeUtil with singleton TradeUtil
  * Fix comment typos
  * Refactor PendingTradesViewModel methods -> TradeUtil & OfferUtil

-- File Changes --

    M core/src/main/java/bisq/core/api/model/OfferInfo.java (8)
    M core/src/main/java/bisq/core/api/model/TradeInfo.java (133)
    M core/src/main/java/bisq/core/offer/OfferUtil.java (4)
    M core/src/main/java/bisq/core/offer/takeoffer/TakeOfferModel.java (38)
    M core/src/main/java/bisq/core/trade/TradeManager.java (5)
    A core/src/main/java/bisq/core/trade/TradeUtil.java (207)
    D core/src/main/java/bisq/core/trade/TradeUtils.java (79)
    M core/src/main/java/bisq/core/trade/failed/FailedTradesManager.java (7)
    M desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/PendingTradesViewModel.java (112)
    M proto/src/main/proto/grpc.proto (29)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/4699.patch
https://github.com/bisq-network/bisq/pull/4699.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4699
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20201025/cc4d15f2/attachment.html>


More information about the bisq-github mailing list