[bisq-network/bisq] Refactor PendingTradesDataModel methods -> TradeUtil (#4700)

[Stan]

Scope of this refactoring is small;  more can be done, but the short term goal of the trade utils refactoring is to share trade util logic with core api.
    
- Removed unused method getCurrencyCode()
- Made minor style changes
- Removed duplicated code block

PR https://github.com/bisq-network/bisq/pull/4699 should be reviewed & merged before this PR.
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/4700

-- Commit Summary --

  * Block on tx-fee-request in core TakeOfferModel init
  * Add compiler warning suppression, remove comment
  * Add fields to grpc TradeInfo proto & wrapper
  * Replace static TradeUtil with singleton TradeUtil
  * Fix comment typos
  * Refactor PendingTradesViewModel methods -> TradeUtil & OfferUtil
  * Remove trailing spaces for codacy
  * Refactor PendingTradesDataModel methods -> TradeUtil

-- File Changes --

    M core/src/main/java/bisq/core/api/model/OfferInfo.java (8)
    M core/src/main/java/bisq/core/api/model/TradeInfo.java (133)
    M core/src/main/java/bisq/core/offer/OfferUtil.java (4)
    M core/src/main/java/bisq/core/offer/takeoffer/TakeOfferModel.java (38)
    M core/src/main/java/bisq/core/trade/TradeManager.java (5)
    A core/src/main/java/bisq/core/trade/TradeUtil.java (209)
    D core/src/main/java/bisq/core/trade/TradeUtils.java (79)
    M core/src/main/java/bisq/core/trade/failed/FailedTradesManager.java (7)
    M desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/PendingTradesDataModel.java (83)
    M desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/PendingTradesViewModel.java (110)
    M proto/src/main/proto/grpc.proto (29)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/4700.patch
https://github.com/bisq-network/bisq/pull/4700.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4700
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20201025/d37ea683/attachment.html>