[bisq-network/bisq] Refactor CLI output formatting code & add trade formatter (#4703)
Stan
notifications at github.com
Sun Oct 25 19:55:42 UTC 2020
- Move output column header specs to its own shared constants class.
- Add new TradeFormat class for printing trade details in the console.
- Print formatted trade in api trade tests -- to see output before using formatter in CLI (in next PR).
PR https://github.com/bisq-network/bisq/pull/4701 should be reviewed & merged before this PR.
You can view, comment on, or merge this pull request online at:
https://github.com/bisq-network/bisq/pull/4703
-- Commit Summary --
* Block on tx-fee-request in core TakeOfferModel init
* Add compiler warning suppression, remove comment
* Add fields to grpc TradeInfo proto & wrapper
* Replace static TradeUtil with singleton TradeUtil
* Fix comment typos
* Refactor PendingTradesViewModel methods -> TradeUtil & OfferUtil
* Remove trailing spaces for codacy
* Refactor PendingTradesDataModel methods -> TradeUtil
* Remove unused import
* Add getRole(tradeId) to core api
* Refactor CLI output formatting code & add trade formatter
* Add license comment
-- File Changes --
M apitest/src/test/java/bisq/apitest/method/trade/AbstractTradeTest.java (1)
M apitest/src/test/java/bisq/apitest/method/trade/TakeBuyBTCOfferTest.java (6)
M apitest/src/test/java/bisq/apitest/method/trade/TakeSellBTCOfferTest.java (7)
A cli/src/main/java/bisq/cli/ColumnHeaderConstants.java (55)
M cli/src/main/java/bisq/cli/TableFormat.java (26)
A cli/src/main/java/bisq/cli/TradeFormat.java (119)
M core/src/main/java/bisq/core/api/CoreApi.java (4)
M core/src/main/java/bisq/core/api/CoreTradesService.java (9)
M core/src/main/java/bisq/core/api/model/OfferInfo.java (8)
M core/src/main/java/bisq/core/api/model/TradeInfo.java (148)
M core/src/main/java/bisq/core/offer/OfferUtil.java (4)
M core/src/main/java/bisq/core/offer/takeoffer/TakeOfferModel.java (38)
M core/src/main/java/bisq/core/trade/TradeManager.java (5)
A core/src/main/java/bisq/core/trade/TradeUtil.java (228)
D core/src/main/java/bisq/core/trade/TradeUtils.java (79)
M core/src/main/java/bisq/core/trade/failed/FailedTradesManager.java (7)
M daemon/src/main/java/bisq/daemon/grpc/GrpcTradesService.java (3)
M desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/PendingTradesDataModel.java (83)
M desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/PendingTradesViewModel.java (110)
M proto/src/main/proto/grpc.proto (30)
-- Patch Links --
https://github.com/bisq-network/bisq/pull/4703.patch
https://github.com/bisq-network/bisq/pull/4703.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4703
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20201025/ec3a5e92/attachment-0001.html>
More information about the bisq-github
mailing list