[bisq-network/bisq] Stub out api methods 'keepfunds', 'withdrawfunds' (#4709)

[Stan]

This PR adds trade closing methods to the api:
 
1.  `keepfunds trade-id`  --  keep trade funds in the Bisq wallet
2.  `withdrawfunds trade-id, address`  -- send trade funds to an external BTC wallet

Changes:
- Add grpc protos
- Add new methods to GrpcTradesService, CoreApi
- Stub out implementations in CoreTradesService
- Add methods to CLI

PR https://github.com/bisq-network/bisq/pull/4705 should be reviewed & merged before this PR.
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/4709

-- Commit Summary --

  * Block on tx-fee-request in core TakeOfferModel init
  * Add compiler warning suppression, remove comment
  * Add fields to grpc TradeInfo proto & wrapper
  * Replace static TradeUtil with singleton TradeUtil
  * Fix comment typos
  * Refactor PendingTradesViewModel methods -> TradeUtil & OfferUtil
  * Remove trailing spaces for codacy
  * Refactor PendingTradesDataModel methods -> TradeUtil
  * Remove unused import
  * Add getRole(tradeId) to core api
  * Refactor CLI output formatting code & add trade formatter
  * Add license comment
  * Move semicolon up from blank line
  * Add 'gettrade' to api method CLI
  * Add boolean 'showcontract' argument to api's 'gettrade'
  * Stub out api methods 'keepfunds', 'withdrawfunds'

-- File Changes --

    M apitest/src/test/java/bisq/apitest/method/trade/AbstractTradeTest.java (1)
    M apitest/src/test/java/bisq/apitest/method/trade/TakeBuyBTCOfferTest.java (6)
    M apitest/src/test/java/bisq/apitest/method/trade/TakeSellBTCOfferTest.java (7)
    M cli/src/main/java/bisq/cli/CliMain.java (54)
    A cli/src/main/java/bisq/cli/ColumnHeaderConstants.java (55)
    M cli/src/main/java/bisq/cli/TableFormat.java (26)
    A cli/src/main/java/bisq/cli/TradeFormat.java (118)
    M core/src/main/java/bisq/core/api/CoreApi.java (12)
    M core/src/main/java/bisq/core/api/CoreTradesService.java (19)
    M core/src/main/java/bisq/core/api/model/OfferInfo.java (8)
    M core/src/main/java/bisq/core/api/model/TradeInfo.java (148)
    M core/src/main/java/bisq/core/offer/OfferUtil.java (4)
    M core/src/main/java/bisq/core/offer/takeoffer/TakeOfferModel.java (38)
    M core/src/main/java/bisq/core/trade/TradeManager.java (5)
    A core/src/main/java/bisq/core/trade/TradeUtil.java (228)
    D core/src/main/java/bisq/core/trade/TradeUtils.java (79)
    M core/src/main/java/bisq/core/trade/failed/FailedTradesManager.java (7)
    M daemon/src/main/java/bisq/daemon/grpc/GrpcTradesService.java (37)
    M desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/PendingTradesDataModel.java (83)
    M desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/PendingTradesViewModel.java (110)
    M proto/src/main/proto/grpc.proto (49)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/4709.patch
https://github.com/bisq-network/bisq/pull/4709.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4709
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20201026/5183c965/attachment-0001.html>