[bisq-network/bisq] Cleaner formatting for trading charts date axes (#4715)

deusmax notifications at github.com
Tue Oct 27 19:27:18 UTC 2020


Clean up date axes style for easy reading. Made date labels shorter,
with clear visual correspondence to relevant axes tick mark.
Tick marks with labels are now larger than those without.

<!-- 
- make yourself familiar with the CONTRIBUTING.md if you have not already (https://github.com/bisq-network/bisq/blob/master/CONTRIBUTING.md)
- make sure you follow our [coding style guidelines][https://github.com/bisq-network/style/issues)
- pick a descriptive title
- provide some meaningful PR description below
- create the PR
- in case you receive a "Change request" and/or a NACK, please react within 30 days. If not, we will close your PR and it can not be up for compensation.
- After addressing the change request, __please re-request a review!__ Otherwise we might miss your PR as we tend to only look at pull requests tagged with a "review required".
-->

Currently, the X-axis for the Price and Volume charts is not well designed. The labels are large, all the tick marks are the same. It is difficult to estimate to which tick mark the date label corresponds.  Here is a typical example for the DAY interval:
![Bisq-chartaxes-day_orig-2020-10-27](https://user-images.githubusercontent.com/142019/97351164-0c942e00-189a-11eb-9d90-efb66982e7c0.png)


The fix proposed here draws the labels more compact and the respective ticks stand-out. The chart view becomes cleaner and more visually intuitive. Above example, becomes:
![Bisq-chartaxes-day_new-2020-10-27](https://user-images.githubusercontent.com/142019/97351201-187ff000-189a-11eb-8c87-4bee28332fb1.png)

The labels take less horizontal space by splitting into 2-levels, using 24-hour time instead of AM/PM. The examples here show English locale, though localization for the month names is maintained, as before.

Of course, further customization is possible, but the above, I feel, provides an acceptable improvement to chart display, without deviating from the current UI or introducing new features.

Similar results are obtained with the other chart interval  values. Examples (10min, HOUR, WEEK, MOTH):
![Bisq-chartaxes-10min_new-2020-10-27](https://user-images.githubusercontent.com/142019/97348987-955d9a80-1897-11eb-9991-7abe3213aff8.png)
![Bisq-chartaxes-hour_new-2020-10-27](https://user-images.githubusercontent.com/142019/97349048-a27a8980-1897-11eb-8ea7-d4ca27d58e41.png)
![Bisq-chartaxes-week_new-2020-10-27](https://user-images.githubusercontent.com/142019/97349073-adcdb500-1897-11eb-9610-854ae7685803.png)
![Bisq-chartaxes-month_new-2020-10-27](https://user-images.githubusercontent.com/142019/97349093-b625f000-1897-11eb-8779-d9694558ad6a.png)

Bisq is a unique tool. It deserves better charts.
Hope you find this a small improvement in the right direction.


You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/4715

-- Commit Summary --

  * Cleaner formatting for trading charts date axes

-- File Changes --

    M desktop/src/main/java/bisq/desktop/main/market/trades/TradesChartsView.java (14)
    M desktop/src/main/java/bisq/desktop/main/market/trades/charts/price/CandleStickChart.java (2)
    M desktop/src/main/java/bisq/desktop/main/market/trades/charts/volume/VolumeChart.java (2)
    M desktop/src/main/java/bisq/desktop/util/DisplayUtils.java (19)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/4715.patch
https://github.com/bisq-network/bisq/pull/4715.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4715
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20201027/9a0aaaf9/attachment.html>


More information about the bisq-github mailing list