[bisq-network/bisq] [WIP] Migrate method tests to scenario test cases (#4717)
Stan
notifications at github.com
Tue Oct 27 23:02:37 UTC 2020
The reason for doing this is to cut test time by reducing scaffold setup repetitions while not moving or changing `method` test code.
`method` tests can be enabled and run at any time by commenting out their class level `@Disabled` annotations.
The first test cases to be migrated are wallet tests:
- `FundWalletScenarioTest` is renamed `WalletTest`
- `GetBalanceTest` was `@Disabled` at the class level
- All `GetBalanceTest` unit tests are run from `WalletTest`
PR https://github.com/bisq-network/bisq/pull/4716 should be reviewed & merged before this PR.
_This PR is not marked draft so codacy will do it's thang._
You can view, comment on, or merge this pull request online at:
https://github.com/bisq-network/bisq/pull/4717
-- Commit Summary --
* Block on tx-fee-request in core TakeOfferModel init
* Add compiler warning suppression, remove comment
* Add fields to grpc TradeInfo proto & wrapper
* Replace static TradeUtil with singleton TradeUtil
* Fix comment typos
* Refactor PendingTradesViewModel methods -> TradeUtil & OfferUtil
* Remove trailing spaces for codacy
* Refactor PendingTradesDataModel methods -> TradeUtil
* Remove unused import
* Add getRole(tradeId) to core api
* Refactor CLI output formatting code & add trade formatter
* Add license comment
* Move semicolon up from blank line
* Add 'gettrade' to api method CLI
* Add boolean 'showcontract' argument to api's 'gettrade'
* Stub out api methods 'keepfunds', 'withdrawfunds'
* Implement api methods 'keepfunds', 'withdrawfunds'
* Make formatSatoshis visible for testing
* Add method for printing current jupiter test name
* Test trade closing api methods 'keepfunds' withdrawfunds'
* Fix apitest dummy payment acct init bug
* Stub out canceloffer api method
* Fix typo
* Implement api method 'canceloffer'
* Add canceloffer test
* Consolidate all wallet tests into one scenario test
-- File Changes --
M apitest/src/test/java/bisq/apitest/ApiTestCase.java (8)
M apitest/src/test/java/bisq/apitest/method/GetBalanceTest.java (3)
M apitest/src/test/java/bisq/apitest/method/MethodTest.java (56)
M apitest/src/test/java/bisq/apitest/method/RegisterDisputeAgentsTest.java (12)
M apitest/src/test/java/bisq/apitest/method/WalletProtectionTest.java (2)
M apitest/src/test/java/bisq/apitest/method/offer/AbstractOfferTest.java (14)
A apitest/src/test/java/bisq/apitest/method/offer/CancelOfferTest.java (81)
M apitest/src/test/java/bisq/apitest/method/offer/CreateOfferUsingFixedPriceTest.java (23)
M apitest/src/test/java/bisq/apitest/method/offer/CreateOfferUsingMarketPriceMarginTest.java (29)
M apitest/src/test/java/bisq/apitest/method/offer/ValidateCreateOfferTest.java (4)
M apitest/src/test/java/bisq/apitest/method/trade/AbstractTradeTest.java (113)
M apitest/src/test/java/bisq/apitest/method/trade/TakeBuyBTCOfferTest.java (87)
M apitest/src/test/java/bisq/apitest/method/trade/TakeSellBTCOfferTest.java (96)
R apitest/src/test/java/bisq/apitest/scenario/WalletTest.java (36)
M cli/src/main/java/bisq/cli/CliMain.java (69)
A cli/src/main/java/bisq/cli/ColumnHeaderConstants.java (55)
M cli/src/main/java/bisq/cli/CurrencyFormat.java (8)
M cli/src/main/java/bisq/cli/TableFormat.java (26)
A cli/src/main/java/bisq/cli/TradeFormat.java (118)
M core/src/main/java/bisq/core/api/CoreApi.java (16)
M core/src/main/java/bisq/core/api/CoreOffersService.java (10)
M core/src/main/java/bisq/core/api/CoreTradesService.java (129)
M core/src/main/java/bisq/core/api/CoreWalletsService.java (6)
M core/src/main/java/bisq/core/api/model/OfferInfo.java (8)
M core/src/main/java/bisq/core/api/model/TradeInfo.java (148)
M core/src/main/java/bisq/core/offer/OfferUtil.java (4)
M core/src/main/java/bisq/core/offer/takeoffer/TakeOfferModel.java (38)
M core/src/main/java/bisq/core/trade/TradeManager.java (5)
A core/src/main/java/bisq/core/trade/TradeUtil.java (228)
D core/src/main/java/bisq/core/trade/TradeUtils.java (79)
M core/src/main/java/bisq/core/trade/failed/FailedTradesManager.java (7)
M daemon/src/main/java/bisq/daemon/grpc/GrpcOffersService.java (17)
M daemon/src/main/java/bisq/daemon/grpc/GrpcTradesService.java (37)
M desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/PendingTradesDataModel.java (83)
M desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/PendingTradesViewModel.java (110)
M proto/src/main/proto/grpc.proto (58)
-- Patch Links --
https://github.com/bisq-network/bisq/pull/4717.patch
https://github.com/bisq-network/bisq/pull/4717.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4717
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20201027/7817ee5d/attachment.html>
More information about the bisq-github
mailing list