[bisq-network/compensation] For Cycle 18 (#685)

[Florian Reimair]

> though that got transformed to a huge extent

I disagree. Yes, coding style changed a lot, yes, the "version" information has its own protocol field now, and yes, stuff only applies to TradeStatistics now. But overall, the business logic did not change too much and I could have made these changes with very little efforts based on my ready-to-ship PR. However, the project was defined as is halve a year ago (by a group of people) I was not aware of the new requirements. You pretty much took a finished solution and refactored it. Also consider, that sq, aka the reviewer, and I had in-depth discussions on how stuff works and that it is a big and risky step. The reviewer therefore knew the concept of the PR already, and hence, did not have to invest too much time into thinking through a whole new PR.

> For not merged code there is usually no compensation. 

That kind-of changed with the rise of the projects concept. Projects have been introduced to reduce the risk of big changes not being compensated and thus, encourage more people to do bigger projects and thus, really improve Bisq. Unfortunately, since the project concept has been introduced, pretty much only I adopted the process for non-management projects and only 2 projects got closed (the KPIs and https://github.com/bisq-network/projects/issues/25) so far.

> The 3200 USD for bisq-network/projects#25 seems a bit high to me. 

Well then make a suggestion.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/compensation/issues/685#issuecomment-717750555
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20201028/5c589087/attachment.html>