[bisq-network/bisq] Reduce apitest suite execution time (#4725)

Stan notifications at github.com
Wed Oct 28 21:23:26 UTC 2020


Reduce `apitest` suite execution time

Consolidated all method tests into fewer test cases by running them from new 'scenario' test cases.  This cuts the current scaffold  setup & tear-down times by almost 1/2.  No method tests were deleted or duplicated.

(1)  Disabled all method (unit) test cases at the class level.
(2)  Added new scenario test cases to run all disabled test cases (1).

The method test cases can still be run by commenting out their `@Disabled` annotations.

PR https://github.com/bisq-network/bisq/pull/4724 should be reviewed & merged before this PR.
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/4725

-- Commit Summary --

  * Block on tx-fee-request in core TakeOfferModel init
  * Add compiler warning suppression, remove comment
  * Add fields to grpc TradeInfo proto & wrapper
  * Replace static TradeUtil with singleton TradeUtil
  * Fix comment typos
  * Refactor PendingTradesViewModel methods -> TradeUtil & OfferUtil
  * Remove trailing spaces for codacy
  * Refactor PendingTradesDataModel methods -> TradeUtil
  * Remove unused import
  * Add getRole(tradeId) to core api
  * Refactor CLI output formatting code & add trade formatter
  * Add license comment
  * Move semicolon up from blank line
  * Add 'gettrade' to api method CLI
  * Add boolean 'showcontract' argument to api's 'gettrade'
  * Stub out api methods 'keepfunds', 'withdrawfunds'
  * Implement api methods 'keepfunds', 'withdrawfunds'
  * Make formatSatoshis visible for testing
  * Add method for printing current jupiter test name
  * Test trade closing api methods 'keepfunds' withdrawfunds'
  * Fix apitest dummy payment acct init bug
  * Stub out canceloffer api method
  * Fix typo
  * Implement api method 'canceloffer'
  * Add canceloffer test
  * Upgrade jupiterVersion = '5.7.0'
  * Improve apitest cmd line console logging
  * Remove dead code
  * Refactor api test fixture setup
  * Remove redundant ScenarioTest superclass
  * Reduce apitest case execution time

-- File Changes --

    M apitest/src/main/java/bisq/apitest/linux/AbstractLinuxProcess.java (2)
    M apitest/src/test/java/bisq/apitest/ApiTestCase.java (8)
    M apitest/src/test/java/bisq/apitest/method/CreatePaymentAccountTest.java (3)
    M apitest/src/test/java/bisq/apitest/method/GetBalanceTest.java (3)
    M apitest/src/test/java/bisq/apitest/method/GetVersionTest.java (3)
    M apitest/src/test/java/bisq/apitest/method/MethodTest.java (84)
    M apitest/src/test/java/bisq/apitest/method/RegisterDisputeAgentsTest.java (14)
    M apitest/src/test/java/bisq/apitest/method/WalletProtectionTest.java (2)
    M apitest/src/test/java/bisq/apitest/method/offer/AbstractOfferTest.java (32)
    A apitest/src/test/java/bisq/apitest/method/offer/CancelOfferTest.java (82)
    M apitest/src/test/java/bisq/apitest/method/offer/CreateOfferUsingFixedPriceTest.java (24)
    M apitest/src/test/java/bisq/apitest/method/offer/CreateOfferUsingMarketPriceMarginTest.java (31)
    M apitest/src/test/java/bisq/apitest/method/offer/ValidateCreateOfferTest.java (6)
    M apitest/src/test/java/bisq/apitest/method/trade/AbstractTradeTest.java (42)
    A apitest/src/test/java/bisq/apitest/method/trade/ExpectedProtocolStatus.java (69)
    M apitest/src/test/java/bisq/apitest/method/trade/TakeBuyBTCOfferTest.java (89)
    M apitest/src/test/java/bisq/apitest/method/trade/TakeSellBTCOfferTest.java (98)
    M apitest/src/test/java/bisq/apitest/scenario/FundWalletScenarioTest.java (6)
    A apitest/src/test/java/bisq/apitest/scenario/OfferTest.java (72)
    D apitest/src/test/java/bisq/apitest/scenario/ScenarioTest.java (28)
    A apitest/src/test/java/bisq/apitest/scenario/StartupTest.java (85)
    A apitest/src/test/java/bisq/apitest/scenario/TradeTest.java (64)
    A apitest/src/test/java/bisq/apitest/scenario/WalletTest.java (99)
    M build.gradle (33)
    M cli/src/main/java/bisq/cli/CliMain.java (69)
    A cli/src/main/java/bisq/cli/ColumnHeaderConstants.java (55)
    M cli/src/main/java/bisq/cli/CurrencyFormat.java (8)
    M cli/src/main/java/bisq/cli/TableFormat.java (26)
    A cli/src/main/java/bisq/cli/TradeFormat.java (118)
    M core/src/main/java/bisq/core/api/CoreApi.java (16)
    M core/src/main/java/bisq/core/api/CoreOffersService.java (10)
    M core/src/main/java/bisq/core/api/CoreTradesService.java (129)
    M core/src/main/java/bisq/core/api/CoreWalletsService.java (6)
    M core/src/main/java/bisq/core/api/model/OfferInfo.java (8)
    M core/src/main/java/bisq/core/api/model/TradeInfo.java (148)
    M core/src/main/java/bisq/core/offer/OfferUtil.java (4)
    M core/src/main/java/bisq/core/offer/takeoffer/TakeOfferModel.java (38)
    M core/src/main/java/bisq/core/trade/TradeManager.java (5)
    A core/src/main/java/bisq/core/trade/TradeUtil.java (228)
    D core/src/main/java/bisq/core/trade/TradeUtils.java (79)
    M core/src/main/java/bisq/core/trade/failed/FailedTradesManager.java (7)
    M daemon/src/main/java/bisq/daemon/grpc/GrpcOffersService.java (17)
    M daemon/src/main/java/bisq/daemon/grpc/GrpcTradesService.java (37)
    M desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/PendingTradesDataModel.java (83)
    M desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/PendingTradesViewModel.java (110)
    M proto/src/main/proto/grpc.proto (58)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/4725.patch
https://github.com/bisq-network/bisq/pull/4725.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4725
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20201028/adf7dc80/attachment-0001.html>


More information about the bisq-github mailing list