[bisq-network/bisq] Refactor PendingTradesViewModel methods -> TradeUtil & OfferUtil (#4699)

Stan notifications at github.com
Thu Oct 29 23:17:35 UTC 2020


@ghubstan commented on this pull request.



>      }
 
     public String getRemainingTradeDurationAsWords() {
-        return FormattingUtils.formatDurationAsWords(Math.max(0, getRemainingTradeDuration()));
+        return tradeUtil.getRemainingTradeDurationAsWords(dataModel.getTrade());

Fixes for these problems will go into a new 'reviewer's changes' PR based on the last branch in the chain.
OK with you?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4699#discussion_r514620895
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20201029/28083706/attachment.html>


More information about the bisq-github mailing list