[bisq-network/bisq] Remove outliers when calculating BSQ rate (#4706)

[Christoph Atteneder]

> When I click the DAO menu, I get a jfoenix / reflection related NPE:
> 
> ```
> Oct-29 17:48:40.603 [JavaFX Application Thread] ERROR bisq.common.setup.CommonSetup: Uncaught Exception from thread JavaFX Application Thread 
> Oct-29 17:48:40.603 [JavaFX Application Thread] ERROR bisq.common.setup.CommonSetup: throwableMessage= null 
> Oct-29 17:48:40.603 [JavaFX Application Thread] ERROR bisq.common.setup.CommonSetup: throwableClass= class java.lang.NullPointerException 
> Oct-29 17:48:40.604 [JavaFX Application Thread] ERROR bisq.common.setup.CommonSetup: Stack trace:
> java.lang.NullPointerException
> 	at bisq.desktop.components.JFXTextFieldSkinBisqStyle.updateTextPos(JFXTextFieldSkinBisqStyle.java:95)
> 	at bisq.desktop.components.JFXTextFieldSkinBisqStyle.layoutChildren(JFXTextFieldSkinBisqStyle.java:79)
> 	at javafx.scene.control.Control.layoutChildren(Control.java:601)
> 	at javafx.scene.Parent.layout(Parent.java:1204)
> 	at javafx.scene.Parent.layout(Parent.java:1211)
> 	at javafx.scene.Parent.layout(Parent.java:1211)
> 	at javafx.scene.Parent.layout(Parent.java:1211)
> 	at javafx.scene.Parent.layout(Parent.java:1211)
> 	at javafx.scene.Parent.layout(Parent.java:1211)
> 	at javafx.scene.Parent.layout(Parent.java:1211)
> 	at javafx.scene.Parent.layout(Parent.java:1211)
> 	at javafx.scene.Parent.layout(Parent.java:1211)
> 	at javafx.scene.Parent.layout(Parent.java:1211)
> 	at javafx.scene.Parent.layout(Parent.java:1211)
> 	at javafx.scene.Parent.layout(Parent.java:1211)
> 	at javafx.scene.Parent.layout(Parent.java:1211)
> 	at javafx.scene.Parent.layout(Parent.java:1211)
> 	at javafx.scene.Parent.layout(Parent.java:1211)
> 	at javafx.scene.Parent.layout(Parent.java:1211)
> 	at javafx.scene.Scene.doLayoutPass(Scene.java:576)
> 	at javafx.scene.Scene$ScenePulseListener.pulse(Scene.java:2482)
> 	at com.sun.javafx.tk.Toolkit.lambda$runPulse$2(Toolkit.java:412)
> 	at java.base/java.security.AccessController.doPrivileged(AccessController.java:389)
> 	at com.sun.javafx.tk.Toolkit.runPulse(Toolkit.java:411)
> 	at com.sun.javafx.tk.Toolkit.firePulse(Toolkit.java:438)
> 	at com.sun.javafx.tk.quantum.QuantumToolkit.pulse(QuantumToolkit.java:519)
> 	at com.sun.javafx.tk.quantum.QuantumToolkit.pulse(QuantumToolkit.java:499)
> 	at com.sun.javafx.tk.quantum.QuantumToolkit.pulseFromQueue(QuantumToolkit.java:492)
> 	at com.sun.javafx.tk.quantum.QuantumToolkit.lambda$runToolkit$11(QuantumToolkit.java:320)
> 	at com.sun.glass.ui.InvokeLaterDispatcher$Future.run(InvokeLaterDispatcher.java:96)
> 	at com.sun.glass.ui.gtk.GtkApplication._runLoop(Native Method)
> 	at com.sun.glass.ui.gtk.GtkApplication.lambda$runLoop$11(GtkApplication.java:277)
> 	at java.base/java.lang.Thread.run(Thread.java:835)
> ```
> 
> It's happened after three startups -- two of them on a fresh data directory. I do think it is related to the current `jfoenix-9.0.6.jar` imcompatibility with JDK 11+, in combination with this change.
> 
> I am using OpenJDK 12 on Ubuntu 12.
> 
> Related PRs: #4443 #4463 #4242

This is a jFoenix issue with OpenJDK 12 quite sure. Should be gone when #4242 is merged and we use the newer jFoenix version.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4706#issuecomment-719451126
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20201030/9430d888/attachment-0001.html>