[bisq-network/bisq] [WIP] Resolves issues found in reviewed PRs 4699 [, ...] (#4731)

[Stan]

A chain of 18 PRs are being reviewed in parent-branch -> child-branch order, and the reviewer agreed to allow me to put requested changes into its own PR branch -- this one, the final branch of the chain.

The first two commits resolve issues in https://github.com/bisq-network/bisq/pull/4699.

When all issues in the PR chain are resolved here, this PR will move from draft to ready for review status.

You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/4731

-- Commit Summary --

  * Implement api methods 'keepfunds', 'withdrawfunds'
  * Make formatSatoshis visible for testing
  * Add method for printing current jupiter test name
  * Test trade closing api methods 'keepfunds' withdrawfunds'
  * Fix apitest dummy payment acct init bug
  * Stub out canceloffer api method
  * Fix typo
  * Implement api method 'canceloffer'
  * Add canceloffer test
  * Upgrade jupiterVersion = '5.7.0'
  * Improve apitest cmd line console logging
  * Remove dead code
  * Refactor api test fixture setup
  * Remove redundant ScenarioTest superclass
  * Reduce apitest case execution time
  * Add null checks in PendingTradesViewModel
  * Simplify TradeUtil#getPaymentMethodNameWithCountryCode

-- File Changes --

    M apitest/src/main/java/bisq/apitest/linux/AbstractLinuxProcess.java (2)
    M apitest/src/test/java/bisq/apitest/ApiTestCase.java (8)
    M apitest/src/test/java/bisq/apitest/method/CreatePaymentAccountTest.java (3)
    M apitest/src/test/java/bisq/apitest/method/GetBalanceTest.java (3)
    M apitest/src/test/java/bisq/apitest/method/GetVersionTest.java (3)
    M apitest/src/test/java/bisq/apitest/method/MethodTest.java (84)
    M apitest/src/test/java/bisq/apitest/method/RegisterDisputeAgentsTest.java (14)
    M apitest/src/test/java/bisq/apitest/method/WalletProtectionTest.java (2)
    M apitest/src/test/java/bisq/apitest/method/offer/AbstractOfferTest.java (32)
    A apitest/src/test/java/bisq/apitest/method/offer/CancelOfferTest.java (82)
    M apitest/src/test/java/bisq/apitest/method/offer/CreateOfferUsingFixedPriceTest.java (24)
    M apitest/src/test/java/bisq/apitest/method/offer/CreateOfferUsingMarketPriceMarginTest.java (31)
    M apitest/src/test/java/bisq/apitest/method/offer/ValidateCreateOfferTest.java (6)
    M apitest/src/test/java/bisq/apitest/method/trade/AbstractTradeTest.java (43)
    A apitest/src/test/java/bisq/apitest/method/trade/ExpectedProtocolStatus.java (69)
    M apitest/src/test/java/bisq/apitest/method/trade/TakeBuyBTCOfferTest.java (95)
    M apitest/src/test/java/bisq/apitest/method/trade/TakeSellBTCOfferTest.java (105)
    M apitest/src/test/java/bisq/apitest/scenario/FundWalletScenarioTest.java (6)
    A apitest/src/test/java/bisq/apitest/scenario/OfferTest.java (72)
    D apitest/src/test/java/bisq/apitest/scenario/ScenarioTest.java (28)
    A apitest/src/test/java/bisq/apitest/scenario/StartupTest.java (85)
    A apitest/src/test/java/bisq/apitest/scenario/TradeTest.java (64)
    A apitest/src/test/java/bisq/apitest/scenario/WalletTest.java (99)
    M build.gradle (33)
    M cli/src/main/java/bisq/cli/CliMain.java (15)
    M cli/src/main/java/bisq/cli/CurrencyFormat.java (8)
    M core/src/main/java/bisq/core/api/CoreApi.java (4)
    M core/src/main/java/bisq/core/api/CoreOffersService.java (10)
    M core/src/main/java/bisq/core/api/CoreTradesService.java (120)
    M core/src/main/java/bisq/core/api/CoreWalletsService.java (6)
    M core/src/main/java/bisq/core/trade/TradeUtil.java (15)
    M daemon/src/main/java/bisq/daemon/grpc/GrpcOffersService.java (17)
    M desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/PendingTradesViewModel.java (4)
    M proto/src/main/proto/grpc.proto (9)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/4731.patch
https://github.com/bisq-network/bisq/pull/4731.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4731
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20201030/5d43e759/attachment-0001.html>