[bisq-network/bisq] Allow user-defined block explorers (#4733)
James Cox
notifications at github.com
Sat Oct 31 03:42:21 UTC 2020
In Settings/General Preferences the Bitcoin Explorer and Bisq Explorer may now be user defined in addition to the hard coded block explorer choices.
This implementation takes advantage of the existing Protobuf implementation that stores a BlockExplorer Name/UrlTx/UrlAddress for BTC and for BSQ.
A new popup dialog is implemented which allows editing of the explorer details (name, txUrl, and addressUrl). Any of the system-defined explorer details may be selected into the edit fields thus allowing them to be used as templates, customized or an entirely new explorer to be used.
If the user switches choice from a customized back to a pre-defined explorer then the customized settings are gone; this is because the Protobuf storage only allows saving one selection.
Fixes #4371
Closes #4634
![image](https://user-images.githubusercontent.com/47253594/97770395-dd332a80-1b00-11eb-85c8-cf91fbe52e85.png)
![image](https://user-images.githubusercontent.com/47253594/97770404-f8059f00-1b00-11eb-9e0f-2f7f7f2fdae3.png)
You can view, comment on, or merge this pull request online at:
https://github.com/bisq-network/bisq/pull/4733
-- Commit Summary --
* Allow user-defined block explorers
-- File Changes --
M core/src/main/java/bisq/core/user/Preferences.java (13)
M core/src/main/resources/i18n/displayStrings.properties (8)
A desktop/src/main/java/bisq/desktop/main/overlays/windows/EditCustomExplorerWindow.java (198)
M desktop/src/main/java/bisq/desktop/main/settings/preferences/PreferencesView.java (91)
M desktop/src/main/java/bisq/desktop/util/FormBuilder.java (25)
-- Patch Links --
https://github.com/bisq-network/bisq/pull/4733.patch
https://github.com/bisq-network/bisq/pull/4733.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4733
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20201030/00fda0df/attachment.html>
More information about the bisq-github
mailing list