[bisq-network/bisq] Add xmr tx key service 3 (#4458)

chimp1984 notifications at github.com
Tue Sep 1 05:58:08 UTC 2020


<!-- 
- make yourself familiar with the CONTRIBUTING.md if you have not already (https://github.com/bisq-network/bisq/blob/master/CONTRIBUTING.md)
- make sure you follow our [coding style guidelines][https://github.com/bisq-network/style/issues)
- pick a descriptive title
- provide some meaningful PR description below
- create the PR
- in case you receive a "Change request" and/or a NACK, please react within 30 days. If not, we will close your PR and it can not be up for compensation.
- After addressing the change request, __please re-request a review!__ Otherwise we might miss your PR as we tend to only look at pull requests tagged with a "review required".
-->

Fixes #replaceWithIssueNr, fixes #replaceWithIssueNr

Your PR description here.

You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/4458

-- Commit Summary --

  * Add basic support for validation for XMR transfer with tx key
  * Add trade date
  * Implement XMR tx proof autoconfirm feature
  * Merge remote-tracking branch 'origin/master' into add-xmr-tx-key-service-2
  * Add XMR proof result status code TRADE_LIMIT_EXCEEDED
  * Rename XmrProofResult to AutoConfirmResult
  * Persist the auto confirm state of Trade object
  * Default to clearnet XMR proof providers when in dev mode
  * Merge branch 'master_upstream' into xmr
  * Re-word the XMR account creation message per @m52go
  * Update core/src/main/resources/i18n/displayStrings.properties
  * Update core/src/main/resources/i18n/displayStrings.properties
  * - Remove AutoConfirmResult enum from protobuf and add a AutoConfirmResult
  * Add null check for name
  * - Change tolerance from 1 day to 2 hours.
  * - Make REPEAT_REQUEST_PERIOD and MAX_REQUEST_PERIOD static
  * - Add @Nullable
  * Add NO_MATCH_FOUND in comment
  * Add abstract AutoConfirmResult class to get better support if we want
  * No functionality has been changed by that refactoring, just moved
  * Replace success/failure with booleans
  * Apply suggested changes from code analysis
  * No functional change, pure refactoring
  * Merge branch 'add-xmr-tx-key-service-2' into add-xmr-tx-key-service-3
  * Do not pass over xmrAutoConfirmationManager to ProcessModel but use a
  * Various small cleanups...
  * Refactoring: Rename getTextStatus to getStatusAsDisplayString
  * Add @Override, cleanup
  * Improve SetXmrTxKeyWindow
  * Merge branch 'master_upstream' into add-xmr-tx-key-service-3
  * Add devMode check for NO_MATCH case.
  * Refactoring:
  * Refactoring:
  * Refactoring:
  * Refactoring:
  * Remove @nullable from socks5ProxyProvider param
  * Refactor:
  * Refactor:
  * Refactor:
  * Refactor:
  * Refactor:
  * Refactor:
  * Refactor:
  * Refactor:
  * Refactor:
  * Max amount was set to 0.1 BTC, should be 1 BTC
  * Use static field for dev test values
  * Various refactorings, bug fixes and improvements.
  * Update comment
  * dont use restart routing for seed nodes if in devmode
  * Adjust to codacy complaints
  * More refactoring....

-- File Changes --

    M assets/src/main/java/bisq/asset/CryptoNoteAddressValidator.java (216)
    A assets/src/main/java/bisq/asset/CryptoNoteUtils.java (271)
    M common/src/main/java/bisq/common/proto/ProtoUtil.java (10)
    M core/src/main/java/bisq/core/account/witness/AccountAgeWitnessService.java (59)
    M core/src/main/java/bisq/core/app/misc/ExecutableForAppWithP2p.java (5)
    M core/src/main/java/bisq/core/filter/Filter.java (20)
    M core/src/main/java/bisq/core/trade/Trade.java (57)
    M core/src/main/java/bisq/core/trade/TradeManager.java (13)
    A core/src/main/java/bisq/core/trade/autoconf/AssetTxProofResult.java (73)
    A core/src/main/java/bisq/core/trade/autoconf/xmr/XmrTxProofHttpClient.java (27)
    A core/src/main/java/bisq/core/trade/autoconf/xmr/XmrTxProofModel.java (62)
    A core/src/main/java/bisq/core/trade/autoconf/xmr/XmrTxProofParser.java (161)
    A core/src/main/java/bisq/core/trade/autoconf/xmr/XmrTxProofRequest.java (252)
    A core/src/main/java/bisq/core/trade/autoconf/xmr/XmrTxProofRequestService.java (68)
    A core/src/main/java/bisq/core/trade/autoconf/xmr/XmrTxProofService.java (396)
    M core/src/main/java/bisq/core/trade/messages/CounterCurrencyTransferStartedMessage.java (18)
    M core/src/main/java/bisq/core/trade/protocol/tasks/buyer/BuyerSendCounterCurrencyTransferStartedMessage.java (1)
    M core/src/main/java/bisq/core/trade/protocol/tasks/seller/SellerProcessCounterCurrencyTransferStartedMessage.java (13)
    A core/src/main/java/bisq/core/user/AutoConfirmSettings.java (72)
    M core/src/main/java/bisq/core/user/Preferences.java (54)
    M core/src/main/java/bisq/core/user/PreferencesPayload.java (16)
    M core/src/main/resources/i18n/displayStrings.properties (83)
    A core/src/test/java/bisq/core/trade/autoconf/xmr/XmrTxProofParserTest.java (160)
    M core/src/test/java/bisq/core/user/UserPayloadModelVOTest.java (3)
    M core/src/test/java/bisq/core/util/FeeReceiverSelectorTest.java (2)
    M desktop/src/main/java/bisq/desktop/bisq.css (4)
    M desktop/src/main/java/bisq/desktop/main/MainView.java (18)
    M desktop/src/main/java/bisq/desktop/main/MainViewModel.java (12)
    M desktop/src/main/java/bisq/desktop/main/overlays/windows/FilterWindow.java (5)
    A desktop/src/main/java/bisq/desktop/main/overlays/windows/SetXmrTxKeyWindow.java (104)
    M desktop/src/main/java/bisq/desktop/main/overlays/windows/TradeDetailsWindow.java (28)
    M desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/PendingTradesDataModel.java (10)
    M desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/PendingTradesViewModel.java (64)
    M desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/steps/buyer/BuyerStep2View.java (182)
    M desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/steps/buyer/BuyerStep4View.java (19)
    M desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/steps/seller/SellerStep3View.java (54)
    A desktop/src/main/java/bisq/desktop/main/presentation/SettingsPresentation.java (63)
    M desktop/src/main/java/bisq/desktop/main/settings/SettingsView.java (16)
    M desktop/src/main/java/bisq/desktop/main/settings/preferences/PreferencesView.java (172)
    M desktop/src/main/java/bisq/desktop/util/GUIUtil.java (30)
    M proto/src/main/proto/pb.proto (13)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/4458.patch
https://github.com/bisq-network/bisq/pull/4458.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4458
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200831/706f97a5/attachment.html>


More information about the bisq-github mailing list