[bisq-network/bisq] [WIP] Split trade statistics between recent data and historical data (#4405)

Florian Reimair notifications at github.com
Tue Sep 1 12:05:23 UTC 2020


@freimair requested changes on this pull request.

NACK
- pruning will not solve the problem: if bisq grows, we might need to prune after weeks or even days
- adding code does not solve the underlying issue, it is just a risky fix that will be overpowered in months again
- that adds even more complexity right now and down the road with only minimal functional gain
- yet it leaves the existing code, which starts to become overpowered by the requirements and thus, desperately needs fixing, untouched and suffering

Requested Changes: come together in a call and talk about it, and yes, that will be a long one.




-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4405#pullrequestreview-479671953
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200901/d0d52ec6/attachment.html>


More information about the bisq-github mailing list