[bisq-network/bisq] Reduce initial request size (#4233)

Florian Reimair notifications at github.com
Tue Sep 1 12:40:34 UTC 2020


@freimair commented on this pull request.



> @@ -205,24 +214,61 @@ public GetUpdatedDataRequest buildGetUpdatedDataRequest(NodeAddress senderNodeAd
         return new GetUpdatedDataRequest(senderNodeAddress, nonce, this.getKnownPayloadHashes());
     }
 
+    /**
+     * Create the special key. <br><br>

I somehow can agree on 'special key' to not be ideal. Fix coming up...

On the other hand, I fully agree on manipulating Version strings is downright bad and not desirable. However, refactoring `version` format would affect big portions of Bisq. Thus, it would directly violate our doctrine of keeping PR small and right to the point. One has to draw the line somewhere, here it is.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4233#discussion_r481106191
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200901/5e8778b8/attachment-0001.html>


More information about the bisq-github mailing list