[bisq-network/bisq] Refactor filter (#4460)

[chimp1984]

<!-- 
- make yourself familiar with the CONTRIBUTING.md if you have not already (https://github.com/bisq-network/bisq/blob/master/CONTRIBUTING.md)
- make sure you follow our [coding style guidelines][https://github.com/bisq-network/style/issues)
- pick a descriptive title
- provide some meaningful PR description below
- create the PR
- in case you receive a "Change request" and/or a NACK, please react within 30 days. If not, we will close your PR and it can not be up for compensation.
- After addressing the change request, __please re-request a review!__ Otherwise we might miss your PR as we tend to only look at pull requests tagged with a "review required".
-->

Fixes #replaceWithIssueNr, fixes #replaceWithIssueNr

Your PR description here.

You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/4460

-- Commit Summary --

  * Cleanup Filter value object. Remove nullables from old versions. Keep signatureAsBase64 nullable as it is set null at creation time and set later after signing. We use filter protobuf data as input for signature so we have to set signature to null and apply the signature afterwards. To keep object immutable we clone it with static clone method. Similar we handle signature verification. We clone the filter with a null value for the signature and do the validation with that cloned object.
  * Fix tests
  * Merge branch 'master_upstream' into refactor-filter
  * Refactoring
  * Merge branch 'master_upstream' into refactor-filter
  * Fix + prefix in string keys
  * - Add support for multiple pubKeys
  * Remove dev test code
  * Add bannedPrivilegedDevPubKeys field
  * Rename bannedSignerPubKeys to bannedAccountWitnessSignerPubKeys
  * Fix tests
  * Add pub key
  * Add isPrivilegedDevPubKeyBanned method
  * Rename verifySignature to isSignatureValid
  * - Remove isPublicKeyInList check at remove as its irrelevant (dev could

-- File Changes --

    M common/src/main/java/bisq/common/proto/ProtoUtil.java (8)
    M core/src/main/java/bisq/core/account/sign/SignedWitnessService.java (4)
    M core/src/main/java/bisq/core/account/witness/AccountAgeWitnessService.java (8)
    M core/src/main/java/bisq/core/filter/Filter.java (364)
    M core/src/main/java/bisq/core/filter/FilterManager.java (491)
    M core/src/main/java/bisq/core/trade/protocol/tasks/ApplyFilter.java (2)
    M core/src/main/resources/i18n/displayStrings.properties (7)
    M core/src/test/java/bisq/core/account/sign/SignedWitnessServiceTest.java (22)
    M core/src/test/java/bisq/core/account/witness/AccountAgeWitnessServiceTest.java (4)
    M core/src/test/java/bisq/core/user/UserPayloadModelVOTest.java (12)
    M core/src/test/java/bisq/core/util/FeeReceiverSelectorTest.java (29)
    M desktop/src/main/java/bisq/desktop/main/overlays/windows/FilterWindow.java (187)
    M proto/src/main/proto/pb.proto (3)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/4460.patch
https://github.com/bisq-network/bisq/pull/4460.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4460
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200901/3b7c450d/attachment.html>